fix(*): Migrate away from deprecated addSpanProcessor in tests

This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates all usages **in tests** for each package, and
there are no changes to the runtime code.

Ref open-telemetry#2645

plugins/node/instrumentation-cucumber/test/cucumber.test.ts

@@ -53,14 +53,14 @@ import {
 import { PassThrough } from 'stream';
 
 describe('CucumberInstrumentation', () => {
+  const memoryExporter = new InMemorySpanExporter();
+  const spanProcessor = new SimpleSpanProcessor(memoryExporter);
   const provider = new NodeTracerProvider({
     resource: new Resource({
       [SEMRESATTRS_SERVICE_NAME]: 'CucumberInstrumentation',
     }),
+    spanProcessors: [spanProcessor],
   });
-  const memoryExporter = new InMemorySpanExporter();
-  const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
   const contextManager = new AsyncHooksContextManager().enable();
 
   before(() => {

plugins/node/instrumentation-dataloader/test/dataloader.test.ts

@@ -37,12 +37,13 @@ describe('DataloaderInstrumentation', () => {
   let contextManager: AsyncHooksContextManager;
 
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
   const tracer = provider.getTracer('default');
 
   instrumentation.setTracerProvider(provider);
   extraInstrumentation.setTracerProvider(provider);
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
 
   beforeEach(async () => {
     instrumentation.enable();

plugins/node/instrumentation-fs/test/fs.test.ts

@@ -58,10 +58,11 @@ const pluginConfig = {
   createHook,
   endHook,
 };
-const provider = new BasicTracerProvider();
-const tracer = provider.getTracer('default');
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
+const tracer = provider.getTracer('default');
 
 describe('fs instrumentation', () => {
   let contextManager: AsyncHooksContextManager;

plugins/node/instrumentation-fs/test/fsHooks.test.ts

@@ -37,9 +37,10 @@ const pluginConfig = {
   endHook,
 };
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const assertNotHookError = (err?: Error | null) => {
   assert.ok(

plugins/node/instrumentation-fs/test/fsPromises.test.ts

@@ -37,10 +37,11 @@ const endHook = <EndHook>sinon.spy((fnName, { args, span }) => {
 const pluginConfig = {
   endHook,
 };
-const provider = new BasicTracerProvider();
-const tracer = provider.getTracer('default');
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
+const tracer = provider.getTracer('default');
 
 describe('fs/promises instrumentation', () => {
   let contextManager: AsyncHooksContextManager;

plugins/node/instrumentation-fs/test/fsPromisesHooks.test.ts

@@ -37,9 +37,10 @@ const pluginConfig = {
   endHook,
 };
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const assertNotHookError = (err?: Error | null) => {
   assert.ok(

plugins/node/instrumentation-fs/test/parent.test.ts

@@ -25,9 +25,10 @@ import type { FsInstrumentationConfig } from '../src/types';
 import * as api from '@opentelemetry/api';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const tracer = provider.getTracer('default');
 

plugins/node/instrumentation-tedious/test/instrumentation.test.ts

@@ -89,10 +89,12 @@ describe('tedious', () => {
   let tedious: any;
   let contextManager: AsyncHooksContextManager;
   let connection: Connection;
-  const provider = new BasicTracerProvider();
+  const memoryExporter = new InMemorySpanExporter();
+  const provider = new BasicTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
   const shouldTest = process.env.RUN_MSSQL_TESTS; // For CI: assumes local db is already available
   const shouldTestLocally = process.env.RUN_MSSQL_TESTS_LOCAL; // For local: spins up local db via docker
-  const memoryExporter = new InMemorySpanExporter();
 
   before(function (done) {
     if (!(shouldTest || shouldTestLocally) || incompatVersions) {
@@ -101,7 +103,6 @@ describe('tedious', () => {
       this.test!.parent!.pending = true;
       this.skip();
     }
-    provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
     if (shouldTestLocally) {
       testUtils.startDocker('mssql');
       // wait 15 seconds for docker container to start

plugins/node/instrumentation-undici/test/fetch.test.ts

@@ -42,8 +42,9 @@ describe('UndiciInstrumentation `fetch` tests', function () {
   const hostname = 'localhost';
   const mockServer = new MockServer();
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
 
   before(function (done) {
     // Do not test if the `fetch` global API is not available

plugins/node/instrumentation-undici/test/undici.test.ts

@@ -68,8 +68,9 @@ describe('UndiciInstrumentation `undici` tests', function () {
   const hostname = 'localhost';
   const mockServer = new MockServer();
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
 
   before(function (done) {
     // Load `undici`. It may fail if nodejs version is <18 because the module uses

plugins/node/opentelemetry-instrumentation-aws-lambda/test/integrations/lambda-handler.force-flush.test.ts

@@ -88,8 +88,9 @@ describe('force flush', () => {
   });
 
   it('should force flush NodeTracerProvider', async () => {
-    const provider = new NodeTracerProvider();
-    provider.addSpanProcessor(new BatchSpanProcessor(traceMemoryExporter));
+    const provider = new NodeTracerProvider({
+      spanProcessors: [new BatchSpanProcessor(traceMemoryExporter)],
+    });
     provider.register();
     let forceFlushed = false;
     const forceFlush = () =>
@@ -118,10 +119,9 @@ describe('force flush', () => {
   });
 
   it('should force flush ProxyTracerProvider with NodeTracerProvider', async () => {
-    const nodeTracerProvider = new NodeTracerProvider();
-    nodeTracerProvider.addSpanProcessor(
-      new BatchSpanProcessor(traceMemoryExporter)
-    );
+    const nodeTracerProvider = new NodeTracerProvider({
+      spanProcessors: [new BatchSpanProcessor(traceMemoryExporter)],
+    });
     nodeTracerProvider.register();
     const provider = new ProxyTracerProvider();
     provider.setDelegate(nodeTracerProvider);
@@ -183,10 +183,9 @@ describe('force flush', () => {
   });
 
   it('should callback once after force flush providers', async () => {
-    const nodeTracerProvider = new NodeTracerProvider();
-    nodeTracerProvider.addSpanProcessor(
-      new BatchSpanProcessor(traceMemoryExporter)
-    );
+    const nodeTracerProvider = new NodeTracerProvider({
+      spanProcessors: [new BatchSpanProcessor(traceMemoryExporter)],
+    });
     nodeTracerProvider.register();
     const tracerProvider = new ProxyTracerProvider();
     tracerProvider.setDelegate(nodeTracerProvider);

plugins/node/opentelemetry-instrumentation-aws-lambda/test/integrations/lambda-handler.test.ts

@@ -120,8 +120,9 @@ describe('lambda handler', () => {
   ) => {
     process.env._HANDLER = handler;
 
-    const provider = new NodeTracerProvider();
-    provider.addSpanProcessor(new BatchSpanProcessor(memoryExporter));
+    const provider = new NodeTracerProvider({
+      spanProcessors: [new BatchSpanProcessor(memoryExporter)],
+    });
     provider.register();
 
     instrumentation = new AwsLambdaInstrumentation(config);

plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts

@@ -40,11 +40,10 @@ import type * as BunyanLogger from 'bunyan';
 // import { diag, DiagConsoleLogger, DiagLogLevel } from '@opentelemetry/api';
 // diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
 
-const tracerProvider = new NodeTracerProvider();
+const tracerProvider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(new InMemorySpanExporter())],
+});
 tracerProvider.register();
-tracerProvider.addSpanProcessor(
-  new SimpleSpanProcessor(new InMemorySpanExporter())
-);
 const tracer = tracerProvider.getTracer('default');
 
 const resource = new Resource({

plugins/node/opentelemetry-instrumentation-cassandra/test/cassandra-driver.test.ts

@@ -48,8 +48,9 @@ import {
 import { ResponseHookInfo } from '../src/types';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 context.setGlobalContextManager(new AsyncHooksContextManager());
 
 const testCassandra = process.env.RUN_CASSANDRA_TESTS;

plugins/node/opentelemetry-instrumentation-connect/test/instrumentation.test.ts

@@ -50,14 +50,15 @@ const httpRequest = {
 const instrumentation = new ConnectInstrumentation();
 const contextManager = new AsyncHooksContextManager().enable();
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
 const spanProcessor = new SimpleSpanProcessor(memoryExporter);
+const provider = new NodeTracerProvider({
+  spanProcessors: [spanProcessor],
+});
 instrumentation.setTracerProvider(provider);
 context.setGlobalContextManager(contextManager);
 
 const tracer = provider.getTracer('default');
 
-provider.addSpanProcessor(spanProcessor);
 instrumentation.enable();
 
 import * as connect from 'connect';

plugins/node/opentelemetry-instrumentation-dns/test/functionals/dns-disable.test.ts

@@ -26,9 +26,10 @@ import * as Sinon from 'sinon';
 import * as dns from 'dns';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
+const provider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 const tracer = provider.getTracer('default');
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
 
 describe('DnsInstrumentation', () => {
   let instrumentation: DnsInstrumentation;

plugins/node/opentelemetry-instrumentation-dns/test/integrations/dns-lookup.test.ts

@@ -27,8 +27,9 @@ import { assertSpan } from '../utils/assertSpan';
 import { SpanStatusCode } from '@opentelemetry/api';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 describe('dns.lookup()', () => {
   let instrumentation: DnsInstrumentation;

plugins/node/opentelemetry-instrumentation-dns/test/integrations/dns-slash-promises-lookup.test.ts

@@ -27,8 +27,9 @@ import { assertSpan } from '../utils/assertSpan';
 import { SpanStatusCode } from '@opentelemetry/api';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const supportsPromises =
   parseInt(process.versions.node.split('.')[0], 10) >= 15;

plugins/node/opentelemetry-instrumentation-dns/test/integrations/dnspromise-lookup.test.ts

@@ -27,8 +27,9 @@ import { assertSpan } from '../utils/assertSpan';
 import { SpanStatusCode } from '@opentelemetry/api';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 describe('dns.promises.lookup()', () => {
   let instrumentation: DnsInstrumentation;

plugins/node/opentelemetry-instrumentation-express/test/custom-config.test.ts

@@ -39,10 +39,10 @@ import * as express from 'express';
 import * as http from 'http';
 
 describe('ExpressInstrumentation', () => {
-  const provider = new NodeTracerProvider();
   const memoryExporter = new InMemorySpanExporter();
-  const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
   const tracer = provider.getTracer('default');
   const contextManager = new AsyncHooksContextManager().enable();
 

plugins/node/opentelemetry-instrumentation-express/test/express.test.ts

@@ -37,10 +37,11 @@ import { RPCMetadata, getRPCMetadata } from '@opentelemetry/core';
 import { Server } from 'http';
 
 describe('ExpressInstrumentation', () => {
-  const provider = new NodeTracerProvider();
   const memoryExporter = new InMemorySpanExporter();
   const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
+  const provider = new NodeTracerProvider({
+    spanProcessors: [spanProcessor],
+  });
   const tracer = provider.getTracer('default');
   const contextManager = new AsyncHooksContextManager().enable();
 

plugins/node/opentelemetry-instrumentation-express/test/hooks.test.ts

@@ -37,10 +37,11 @@ import { httpRequest, serverWithMiddleware } from './utils';
 import { RPCMetadata, getRPCMetadata } from '@opentelemetry/core';
 
 describe('ExpressInstrumentation hooks', () => {
-  const provider = new NodeTracerProvider();
   const memoryExporter = new InMemorySpanExporter();
   const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
+  const provider = new NodeTracerProvider({
+    spanProcessors: [spanProcessor],
+  });
   const tracer = provider.getTracer('default');
   const contextManager = new AsyncHooksContextManager().enable();
 

plugins/node/opentelemetry-instrumentation-express/test/ignore-all.test.ts

@@ -41,10 +41,11 @@ import * as express from 'express';
 import * as http from 'http';
 
 describe('ExpressInstrumentation', () => {
-  const provider = new NodeTracerProvider();
   const memoryExporter = new InMemorySpanExporter();
   const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
+  const provider = new NodeTracerProvider({
+    spanProcessors: [spanProcessor],
+  });
   const tracer = provider.getTracer('default');
   const contextManager = new AsyncHooksContextManager().enable();
 

plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts

@@ -66,13 +66,14 @@ const httpInstrumentation = new HttpInstrumentation();
 const instrumentation = new FastifyInstrumentation();
 const contextManager = new AsyncHooksContextManager().enable();
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider();
 const spanProcessor = new SimpleSpanProcessor(memoryExporter);
+const provider = new NodeTracerProvider({
+  spanProcessors: [spanProcessor],
+});
 instrumentation.setTracerProvider(provider);
 httpInstrumentation.setTracerProvider(provider);
 context.setGlobalContextManager(contextManager);
 
-provider.addSpanProcessor(spanProcessor);
 instrumentation.enable();
 httpInstrumentation.enable();
 

plugins/node/opentelemetry-instrumentation-generic-pool/test/index.test.ts

@@ -67,10 +67,11 @@ const createPool = {
 }[isOldVersion ? 'v2' : 'v3'];
 
 describe('GenericPool instrumentation', () => {
-  const provider = new NodeTracerProvider();
   const memoryExporter = new InMemorySpanExporter();
   const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
+  const provider = new NodeTracerProvider({
+    spanProcessors: [spanProcessor],
+  });
   plugin.setTracerProvider(provider);
   const tracer = provider.getTracer('default');
   let contextManager: AsyncHooksContextManager;

plugins/node/opentelemetry-instrumentation-graphql/test/graphql.test.ts

@@ -99,8 +99,9 @@ const queryInvalid = `
 `;
 
 const exporter = new InMemorySpanExporter();
-const provider = new BasicTracerProvider();
-provider.addSpanProcessor(new SimpleSpanProcessor(exporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(exporter)],
+});
 graphQLInstrumentation.setTracerProvider(provider);
 
 describe('graphql', () => {