Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dependencies + Adopt/fork rest #372

Open
taoeffect opened this issue Apr 10, 2018 · 4 comments
Open

Get rid of dependencies + Adopt/fork rest #372

taoeffect opened this issue Apr 10, 2018 · 4 comments
Labels
Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced Note:Security Note:Tooling

Comments

@taoeffect
Copy link
Member

taoeffect commented Apr 10, 2018

Problem

We have too many dependencies / third-party libraries. Dependencies are liabilities almost as much as they are assets.

Related issues:

Solution

for (each dependency) {

}

This includes Bulma.

In the end, the only third-party dependencies we should be left with are devDependencies, and even those might not be necessary. As much as possible should be removed or adopted, i.e. we don't need a minifier if our codebase is so small that it doesn't require minification.

In the end, we should get rid of npm and the package-lock.json file as well (since it's so problematic + not helpful). By having our own trimmed-down, audited forks of everything we don't need to worry about new issues arising from updates.

We then don't need to worry about what happens if "npm is down" or "npm is compromised", and we can rely on GPG + git signatures to verify the codebase and commits - Issue #153.

  • Related: update contributing docs to note all of this and discourage new dependencies from being added.

EDIT: this issue can be closed if #586 and #1101 are closed.

taoeffect added a commit to taoeffect/group-income-simple that referenced this issue Aug 4, 2018
hubudibu pushed a commit that referenced this issue Aug 4, 2018
* DEPS: added: flow-typer-js; removed: string sprint-js moment; updated: mocha

* re-added string dep for now

* flow-typer-js validations + improved babelrc + travis tests on node 9

+ flow-typer-js validations to contracts! (Closes #444)
+ told `babel-preset-env` to use past 2 browser versions (Closes #391)
+ travis will now test on nodejs 9
+ frontend `waitTimeout` set to `2000` instead of `60000`

* Updated flow-bin, fixed many flowtype issues, removed bluebird (#372)

* deleted unnecessary test
This was referenced Aug 6, 2018
@taoeffect taoeffect changed the title Get rid of dependencies + Adopt rest Get rid of dependencies + Adopt/fork rest Jul 9, 2019
@taoeffect taoeffect self-assigned this Jul 9, 2019
@CrazedCoding
Copy link
Contributor

CrazedCoding commented Dec 29, 2020

Running:

found 450 vulnerabilities (447 low, 3 high)
  run `npm audit fix` to fix them, or `npm audit` for details
phenomenon@phenomenon:~/group-income-simple-work$ npm audit

Yields:

image
image

Probably should prioritize dropping these packages soon if at all possible.

@snowteamer
Copy link
Collaborator

When attempting to use our own GitHub fork of a dependency, Travis CI complains about not being able to access it, apparently because of some missing access rights:
image

@taoeffect
Copy link
Member Author

@snowteamer I think you need to specify the URL in such a way that it doesn't attempt to access the repo via SSH, but instead uses HTTPS.

@snowteamer
Copy link
Collaborator

snowteamer commented Aug 25, 2021

Using a full commit hash in the dependency specification instead of a branch name, and/or reverting to NPM 6.x seems to bypass the issue.

...
"pug-lint-vue": "github:snowteamer/pug-lint-vue#2702763877bfd1b77c56c81542a22a058e42e952",
...

Relevant NPM issue: npm/cli#2610

@taoeffect taoeffect removed their assignment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced Note:Security Note:Tooling
Projects
None yet
Development

No branches or pull requests

3 participants