-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of dependencies + Adopt/fork rest #372
Labels
Kind:Enhancement
Improvements, new features, performance upgrades, etc.
Level:Advanced
Note:Security
Note:Tooling
Comments
taoeffect
added
Kind:Enhancement
Improvements, new features, performance upgrades, etc.
Note:Up-for-grabs
Note:Security
Note:Tooling
Level:Advanced
labels
Apr 10, 2018
This was referenced Apr 27, 2018
Closed
taoeffect
added a commit
to taoeffect/group-income-simple
that referenced
this issue
Aug 4, 2018
hubudibu
pushed a commit
that referenced
this issue
Aug 4, 2018
* DEPS: added: flow-typer-js; removed: string sprint-js moment; updated: mocha * re-added string dep for now * flow-typer-js validations + improved babelrc + travis tests on node 9 + flow-typer-js validations to contracts! (Closes #444) + told `babel-preset-env` to use past 2 browser versions (Closes #391) + travis will now test on nodejs 9 + frontend `waitTimeout` set to `2000` instead of `60000` * Updated flow-bin, fixed many flowtype issues, removed bluebird (#372) * deleted unnecessary test
This was referenced Aug 6, 2018
Closed
taoeffect
changed the title
Get rid of dependencies + Adopt rest
Get rid of dependencies + Adopt/fork rest
Jul 9, 2019
5 tasks
Closed
This was referenced Mar 25, 2020
Closed
@snowteamer I think you need to specify the URL in such a way that it doesn't attempt to access the repo via SSH, but instead uses HTTPS. |
Using a full commit hash in the dependency specification instead of a branch name, and/or reverting to NPM 6.x seems to bypass the issue. ...
"pug-lint-vue": "github:snowteamer/pug-lint-vue#2702763877bfd1b77c56c81542a22a058e42e952",
... Relevant NPM issue: npm/cli#2610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Kind:Enhancement
Improvements, new features, performance upgrades, etc.
Level:Advanced
Note:Security
Note:Tooling
Problem
We have too many dependencies / third-party libraries. Dependencies are liabilities almost as much as they are assets.
Related issues:
Solution
for (each dependency) {
}
This includes Bulma.
In the end, the only third-party dependencies we should be left with are
devDependencies
, and even those might not be necessary. As much as possible should be removed or adopted, i.e. we don't need a minifier if our codebase is so small that it doesn't require minification.In the end, we should get rid of
npm
and thepackage-lock.json
file as well (since it's so problematic + not helpful). By having our own trimmed-down, audited forks of everything we don't need to worry about new issues arising from updates.We then don't need to worry about what happens if "npm is down" or "npm is compromised", and we can rely on GPG + git signatures to verify the codebase and commits - Issue #153.
EDIT: this issue can be closed if #586 and #1101 are closed.
The text was updated successfully, but these errors were encountered: