Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Bulma into a folder and trim it down to bare essentials #392

Closed
taoeffect opened this issue Apr 29, 2018 · 2 comments
Closed

Copy Bulma into a folder and trim it down to bare essentials #392

taoeffect opened this issue Apr 29, 2018 · 2 comments
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced Priority:Low

Comments

@taoeffect
Copy link
Member

Problem

  • Bulma has more features than we need, increasing page load times and increasing the bundle size
  • Bulma introduces breaking changes frequently
  • Bulma is another dependency (Get rid of dependencies + Adopt/fork rest #372)
  • Bulma might do some things in ways that we don't want (for example, we might want to switch away from SASS/SCSS to PostCSS, or some other thing; @sandrina-p probably has ideas)

Solution

Copy only the files from Bulma that we need into our a subfolder within this project and remove Bulma as a dependency, without changing it too radically so that we can no longer port over new Bulma features.

@sandrina-p
Copy link
Contributor

Switching from SCSS to PostCSS is a solution, but that isn't done in a row. It has to be a thoughtful migration, since Bulma is 100% built in SCSS. At first we can have both working at the same time, since PostCSS has features that SCSS doesn't have (ex: fallback for CSS variables).

Subfolder for Bulma can be the current /bulma_overrides.

@taoeffect
Copy link
Member Author

Closed in #573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced Priority:Low
Projects
None yet
Development

No branches or pull requests

2 participants