Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grunt-svg-sprite #676

Closed
taoeffect opened this issue Sep 20, 2019 · 0 comments · Fixed by #678
Closed

Remove grunt-svg-sprite #676

taoeffect opened this issue Sep 20, 2019 · 0 comments · Fixed by #678

Comments

@taoeffect
Copy link
Member

Problem

grunt-svg-sprite adds too many dependencies, (including a phantom-js download!).

I get that it's useful to be able to automate the optimization of SVGs, but it would be nicer if instead they can just be saved pre-optimized in the repo, without grunt-svg-sprite and all of its dependencies. Plus we need to remove dependencies in general (#372).

Solution

Remove grunt-svg-sprite and run npm dedupe, add all pre-optimized SVGs (optimizing using whatever third-party tool you'd like) instead of originals to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants