Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove moment usage everywhere #874

Closed
taoeffect opened this issue Mar 25, 2020 · 0 comments · Fixed by #880
Closed

Remove moment usage everywhere #874

taoeffect opened this issue Mar 25, 2020 · 0 comments · Fixed by #880
Assignees
@sandrina-p
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter

Comments

@taoeffect
Copy link
Member

Problem

moment dependency is used in a few places in the project, and while it's nice, it's also some ~65k+ (or more?). We want to remove it as well as a bunch of other dependencies (#372) to minimize attack surface and speed up the app.

Solution

Remove it and replace with Date-based usage, e.g.:
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Up-for-grabs App:Frontend Level:Starter labels Mar 25, 2020
@taoeffect taoeffect mentioned this issue Mar 25, 2020
Merged
sandrina-p added a commit that referenced this issue Mar 25, 2020
@sandrina-p
remove moment from dep. #874 will remove its usage
2535dff
sandrina-p added a commit that referenced this issue Mar 26, 2020
@sandrina-p
remove moment from dep. #874 will remove its usage
f2b5bce
taoeffect pushed a commit that referenced this issue Mar 29, 2020
@sandrina-p
#827 finishing touches to group members list (#866)
586f44e 
* Refine groupMembers list

* change new tag to appear for 1 week

* include membersPending on GroupMembersAllModal

* Improve buttonSubmit when reducedMotion is enabled

* Improve groupmembers cypress tests

* Add "new" and "pending" pills to GroupMembersAllModal

* Pixel perfect .pills margins

* changes based on @taoeffect review

* Changes based on @taoeffect review

* Revert "isNewMember" logic to not use moment

* convert joinedData to ms

* remove moment from dep. #874 will remove its usage

* fix fn argument type number -> string

* changes based on @taoeffect review
@sandrina-p sandrina-p self-assigned this Apr 2, 2020
@sandrina-p sandrina-p mentioned this issue Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrina-p sandrina-p

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove moment usage from main codebase okTurtles/group-income
2 participants
@taoeffect @sandrina-p