-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#359 Hedit delete handlings #360
#359 Hedit delete handlings #360
Conversation
…ns slightly upwards
I can help with polish! |
Awesome, do you want to submit a PR on my fork and I will merge you? You can edit in github: |
Update polish.lua
For this resource, it will be unmanagable to go through pain and a lot of delays (getting a translation for every feature that adds a new button/text) every time someone contributes a new feature. It can even deter people from opening PR's, having the (potentially indefinite) delay of it being approved in mind. So im in favour of either:
Any thoughts? mtasa-resources never dealt with resource localization, and now we made this existing resource (hedit) official, which already had its own locale implementation. Using a global localization framework (like Pootle for mtasa-blue) seems overkill in this scenario, and i'm sure no one would work on it (although in the basis of things, it's not ideal that all default resources offer only English.. we can consider setting a target for change in the future) >> EDIT: changed my mind and opened #361 So for now, we can just set specific terms for hedit contributions that require new translations, and i suggest them to be the either one from the list at the beginning of this comment. |
Russian translation is done via Google Translate. Not sure where I can add this to "pending translations". Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated translations should be addressed in a separate PR from the original changes proposed by this PR originally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all translations into separate PR
Note that translation lines from said PR (and also PR #369 as of speaking) use a mix of "success" and "sucess", so it wouldn't work
This PR should close #359
We will need translations for Arabic, Polish, Russian, Spanish and Turkish. Can I use google translate?
I will make this a draft for now, I think I can get Arabic and Spanish but not the rest.