Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#359 Hedit delete handlings #360

Merged
merged 21 commits into from
Nov 22, 2021

Conversation

ricksterhd123
Copy link
Contributor

This PR should close #359
We will need translations for Arabic, Polish, Russian, Spanish and Turkish. Can I use google translate?
I will make this a draft for now, I think I can get Arabic and Spanish but not the rest.

@Inder00
Copy link
Contributor

Inder00 commented Oct 30, 2021

I can help with polish!

@ricksterhd123
Copy link
Contributor Author

ricksterhd123 commented Oct 30, 2021

I can help with polish!

Awesome, do you want to submit a PR on my fork and I will merge you?
This line here needs to be translated from English to Polish the sentence: "Successfully deleted your handling settings!"

You can edit in github:
https://github.com/ricksterhd123/mtasa-resources/blob/hedit-delete-handlings/%5Bgameplay%5D/hedit/client/gui/languages/polish.lua#L39

@Dutchman101
Copy link
Member

Dutchman101 commented Oct 31, 2021

For this resource, it will be unmanagable to go through pain and a lot of delays (getting a translation for every feature that adds a new button/text) every time someone contributes a new feature. It can even deter people from opening PR's, having the (potentially indefinite) delay of it being approved in mind. So im in favour of either:

  • Autotranslate the required text, so it can be merged. Then put it on a list of "unverified translations" that need to be checked off/improved on by a native speaker
  • Don't translate it, so it can be merged. Then put it on a list of "pending translations" (untranslated buttons/texts) for hedit localisation

Any thoughts?

mtasa-resources never dealt with resource localization, and now we made this existing resource (hedit) official, which already had its own locale implementation. Using a global localization framework (like Pootle for mtasa-blue) seems overkill in this scenario, and i'm sure no one would work on it (although in the basis of things, it's not ideal that all default resources offer only English.. we can consider setting a target for change in the future) >> EDIT: changed my mind and opened #361

So for now, we can just set specific terms for hedit contributions that require new translations, and i suggest them to be the either one from the list at the beginning of this comment.

@ricksterhd123 ricksterhd123 marked this pull request as ready for review October 31, 2021 18:24
@ricksterhd123
Copy link
Contributor Author

Russian translation is done via Google Translate. Not sure where I can add this to "pending translations". Ready for review.

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated translations should be addressed in a separate PR from the original changes proposed by this PR originally.

Copy link
Contributor Author

@ricksterhd123 ricksterhd123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved all translations into separate PR

@jlillis jlillis merged commit 0835ecd into multitheftauto:master Nov 22, 2021
Dutchman101 added a commit that referenced this pull request Dec 19, 2021
Note that translation lines from said PR (and also PR #369 as of speaking) use a mix of "success" and "sucess", so it wouldn't work
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hedit: delete handlings
6 participants