Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hedit delete button translations #369

Merged
merged 8 commits into from
Jan 16, 2023
Merged

Hedit delete button translations #369

merged 8 commits into from
Jan 16, 2023

Conversation

ricksterhd123
Copy link
Contributor

@ricksterhd123 ricksterhd123 commented Nov 11, 2021 •
edited
Loading

Once merged this PR will create translations for the delete handling functionality in hedit for all currently supported languages.

I've cherry picked the translation commits out of the PR #360 so that they can be addressed separately.

Once #360 is merged, we might conflicts.

ricksterhd123 and others added 6 commits November 11, 2021 02:36
@ricksterhd123
Add Arabic translation by [SW]Falcon
d7059c1 
(cherry picked from commit a318b2b)
@ricksterhd123
Add Turkish translation by ᴏᴠ | Gürkan
e2fee93 
(cherry picked from commit 3653216)
@ricksterhd123
Merge pull request #3 from Inder00/patch-5
dd21012 
Update polish.lua

(cherry picked from commit c788216)
@ricksterhd123
Add Spanish translation by Fantome
2bb3651 
(cherry picked from commit 76388a6)
@Disinterpreter @ricksterhd123
Update russian.lua
e9170b0 
(cherry picked from commit 62919c9)
@Disinterpreter @ricksterhd123
ru fix typo
89c917e 
(cherry picked from commit fc3aa7c)
@jlillis
Copy link
Contributor

jlillis commented Nov 22, 2021

I've merged #360 - when you feel you have as many translations as you think you're going to get for a while just mark this as ready and I'll review & merge.

Dutchman101 added a commit that referenced this pull request Dec 19, 2021
@Dutchman101
hedit: Fixed typo's introduced in PR #360
6509b74 
Note that translation lines from said PR (and also PR #369 as of speaking) use a mix of "success" and "sucess", so it wouldn't work
@Dutchman101 Dutchman101 self-requested a review December 19, 2021 10:59
Dutchman101
Dutchman101 previously requested changes Dec 19, 2021
View reviewed changes
Copy link
Member

@Dutchman101 Dutchman101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct all typo's in this PR (as in commit 6509b74)

@ricksterhd123
Copy link
Contributor Author

Please correct all typo's in this PR (as in commit 6509b74)

Yes thank you for noticing this I know I wouldn't've ;p
I will try to pick it up later today. I've been procrastinating on this.

@jlillis
Copy link
Contributor

jlillis commented Jan 16, 2023

Circling back on this - do you have any more updates/translations to add, or can we merge what is already here?

@ricksterhd123
Copy link
Contributor Author

Circling back on this - do you have any more updates/translations to add, or can we merge what is already here?

This got abandoned, so nothing in a long time. I'm not sure, I think it was, but let me see if it's still OK, and I'll get back.

ricksterhd123
ricksterhd123 commented Jan 16, 2023
View reviewed changes
Copy link
Contributor Author

@ricksterhd123 ricksterhd123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo requested by Dutch and added translations

@ricksterhd123 ricksterhd123 marked this pull request as ready for review January 16, 2023 23:13
@ricksterhd123
Copy link
Contributor Author

@jlillis I did a quick test and the translations added work, this PR is ready now

@jlillis jlillis dismissed Dutchman101’s stale review January 16, 2023 23:22

Typos fixed as requested

@jlillis jlillis merged commit 2b7439d into multitheftauto:master Jan 16, 2023
@ricksterhd123 ricksterhd123 deleted the hedit-delete-translations branch January 16, 2023 23:24
@patrikjuvonen patrikjuvonen added this to the 1.6.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dutchman101 Dutchman101 Dutchman101 left review comments

Assignees
No one assigned
Labels
enhancement resource:hedit
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ricksterhd123 @jlillis @Dutchman101 @lopezloo @patrikjuvonen @Disinterpreter