-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most of gingko.skip for tests focusing on Conformance #12887
Remove most of gingko.skip for tests focusing on Conformance #12887
Conversation
Any tests that would have been skipped by these regexes have been demoted from Conformance since v1.12, and are now prevented from promotion to Conformance The one exception is [Serial], there are some Conformance tests that we have been as yet unable to rewrite to run safely in parallel.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
|
/lgtm trying to notify the owning SIGs: |
LGTM label has been added. Git tree hash: e90995c9310dc0ad67d4b694601bd114d60938d7
|
/cc @oomichi |
@oomichi yeah their thing is a bit crazy and I'm not going to touch it, one would hope they could eventually just exclude [LinuxOnly] or some tag that denoted functionality they knew wasn't going to work... my goal was solely to strip out the cargo-culted regex |
@spiffxp Thanks for your response, I agree with you. /lgtm |
/hold cancel |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Any tests that would have been skipped by these regexes have been
demoted from Conformance since v1.12, and are now prevented from
promotion to Conformancea (ref:
kubernetes/kubernetes#78710)
The one exception is [Serial], there are some Conformance tests that
we have been as yet unable to rewrite to run safely in parallel.
ref: #9697
/area conformance