Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most of gingko.skip for tests focusing on Conformance #12887

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Remove most of gingko.skip for tests focusing on Conformance #12887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions config/jobs/kubernetes-security/generated-security-jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,7 @@ presubmits:
- --test
- --check-version-skew=false
- --down
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\]
--num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
command:
Expand Down Expand Up @@ -335,8 +334,7 @@ presubmits:
- --test
- --check-version-skew=false
- --down
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\]
--num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
command:
Expand Down Expand Up @@ -418,8 +416,7 @@ presubmits:
- --test
- --check-version-skew=false
- --down
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\]
--num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
command:
Expand Down Expand Up @@ -503,8 +500,7 @@ presubmits:
- --test
- --check-version-skew=false
- --down
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\]
--num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
command:
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-aws/eks/eks-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ periodics:
- --gce-ssh=
- --extract=ci/latest-1.11
- --ginkgo-parallel=30
- --test_args=--ginkgo.flakeAttempts=2 --ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\] --minStartupPods=8
- --test_args=--ginkgo.flakeAttempts=2 --ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Slow\]|\[Serial\] --minStartupPods=8
- --timeout=180m

# Kubernetes performance e2e tests against EKS 1.11 build.
Expand Down
16 changes: 8 additions & 8 deletions config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ periodics:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -129,7 +129,7 @@ periodics:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -208,7 +208,7 @@ periodics:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -287,7 +287,7 @@ periodics:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -364,7 +364,7 @@ presubmits:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -438,7 +438,7 @@ presubmits:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -512,7 +512,7 @@ presubmits:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down Expand Up @@ -588,7 +588,7 @@ presubmits:
- --down
# specific e2e test args
# TODO(bentheelder): num-nodes in particular is brittle. it would be better for kubetest to handle this
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\]|Alpha|Kubectl|\[(Disruptive|Feature:[^\]]+|Flaky)\] --num-nodes=3
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --num-nodes=3
- --ginkgo-parallel
- --timeout=30m
# we need privileged mode in order to do docker in docker
Expand Down
10 changes: 5 additions & 5 deletions config/jobs/kubernetes/sig-gcp/gce-conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-master

Expand All @@ -44,7 +44,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.12

Expand All @@ -65,7 +65,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.13

Expand All @@ -86,7 +86,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.14

Expand All @@ -108,6 +108,6 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.15
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-release/release-branch-jobs/1.12.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.12
name: ""
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-release/release-branch-jobs/1.13.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.13
name: ""
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-release/release-branch-jobs/1.14.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.14
name: ""
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-release/release-branch-jobs/1.15.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ periodics:
- --gcp-node-image=gci
- --gcp-zone=us-west1-b
- --provider=gce
- --test_args=--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]
- --test_args=--ginkgo.focus=\[Conformance\]
- --timeout=200m
image: gcr.io/k8s-testimages/kubekins-e2e:v20190604-3070529-1.15
name: ""
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-testing/coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ periodics:
--gcp-zone=us-west1-b \
--provider=gce \
--timeout=150m \
--test_args="--ginkgo.focus=\[Conformance\] --ginkgo.skip=Alpha|\[(Disruptive|Feature:[^\]]+|Flaky)\]"
--test_args="--ginkgo.focus=\[Conformance\]"
cd ../test-infra
bazel run //gopherage -- merge "${ARTIFACTS}"/before/**/*.cov > "${ARTIFACTS}/before/merged.cov"
bazel run //gopherage -- merge "${ARTIFACTS}"/after/**/*.cov > "${ARTIFACTS}/after/merged.cov"
Expand Down