-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12+ should not exclude kubectl with skip regex for Conformance tests #9697
Comments
/area conformance |
I would much rather complete "pulling the skiplist upstream", aka stripping the Conformance tag from any tests that are skipped by this regex, such that focusing on Conformance is all that's needed |
/area job |
ref: kubernetes/kubernetes#67901 to drop a |
ref: kubernetes/kubernetes#62161 the umbrella issue in k/k for Serial / Flaky / Slow... at present I am only interested in Flaky. Serial and Slow may be necessary evils. |
ref: #9104 where we introduced the skiplist in the first place, this can be considered closed once we've eliminated it |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I stripped the skip regex from the conformance image we are hoping to publish as part of this release kubernetes/kubernetes#74808 (comment) We'll compare the list of tests that runs to the list of tests our jobs run. If they match, let's drop the regex from 1.14 |
/milestone v1.15 I would like to ensure conformance tests are prevented from using these tags ever again |
this bit me submitting the kind 1.14 results (they were accepted though! I amended the next day ❗️), we've removed the skip from kind everywhere (except the parallel / non-serial runs), there might still be something out there using them incorrectly, but those were the last ones I know about. |
Verified the list of tests for v1.15 and v1.14 by using the kind and kind-image jobs, eg: |
I opened kubernetes/kubernetes#78710 to enforce the regex as a gate to promotion to conformance |
Opened #12887 to strip the regex from as many cargo cults as I could find |
/close |
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Work has been done to clean up the conformance suite such that no tests are marked as flaky or disruptive, so updating the documentation so that downstream consumers don't necessarily skip things. New tests are not eligable for promotion to conformance if they match any of these tags. See the following: kubernetes#9697 kubernetes/kubernetes#62161 kubernetes/kubernetes#76344 kubernetes/kubernetes#78710 Signed-off-by: Naadir Jeewa <[email protected]>
heptio/kube-conformance@c4eb36a
we need to:
probably inform sig-cloud-provider members that publish continuous signal to testgrid with kubetest. cc @spiffxp @dims @Katharine
The text was updated successfully, but these errors were encountered: