Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12+ should not exclude kubectl with skip regex for Conformance tests #9697

Closed
BenTheElder opened this issue Oct 4, 2018 · 16 comments
Closed
Assignees
Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/provider/gcp Issues or PRs related to gcp provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@BenTheElder
Copy link
Member

heptio/kube-conformance@c4eb36a

we need to:

  • update master / 1.12 jobs
  • update docs in test-infra, and the community developer guide, possibly elsewhere.

probably inform sig-cloud-provider members that publish continuous signal to testgrid with kubetest. cc @spiffxp @dims @Katharine

@BenTheElder BenTheElder changed the title 1.12+ should not exclude kubectl from skip regex 1.12+ should not exclude kubectl with skip regex for Conformance tests Oct 4, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

/area conformance

ref: heptio/kube-conformance#29

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to kubernetes conformance tests label Oct 4, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

I would much rather complete "pulling the skiplist upstream", aka stripping the Conformance tag from any tests that are skipped by this regex, such that focusing on Conformance is all that's needed

@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

/area job
/sig testing
/sig gcp
/sig architecture
/priority important-soon
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/provider/gcp Issues or PRs related to gcp provider sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 4, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

ref: kubernetes/kubernetes#67901 to drop a [Flaky] test

@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

ref: kubernetes/kubernetes#62161 the umbrella issue in k/k for Serial / Flaky / Slow... at present I am only interested in Flaky. Serial and Slow may be necessary evils.

@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2018

ref: #9104 where we introduced the skiplist in the first place, this can be considered closed once we've eliminated it

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2019
@spiffxp
Copy link
Member

spiffxp commented Jan 3, 2019

/remove-lifecycle stale
/milestone v1.14
Keeping this open as the "pulling the skiplist upstream" issue re: #9697 (comment) unless I find a better issue for it

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 3, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 2, 2019

I stripped the skip regex from the conformance image we are hoping to publish as part of this release kubernetes/kubernetes#74808 (comment)

We'll compare the list of tests that runs to the list of tests our jobs run. If they match, let's drop the regex from 1.14

@spiffxp
Copy link
Member

spiffxp commented May 10, 2019

/milestone v1.15
/assign
I'm pretty sure this is either done, or can be done, I need to verify list of tests

I would like to ensure conformance tests are prevented from using these tags ever again

@BenTheElder
Copy link
Member Author

this bit me submitting the kind 1.14 results (they were accepted though! I amended the next day ❗️), we've removed the skip from kind everywhere (except the parallel / non-serial runs), there might still be something out there using them incorrectly, but those were the last ones I know about.

@spiffxp
Copy link
Member

spiffxp commented Jun 4, 2019

Verified the list of tests for v1.15 and v1.14 by using the kind and kind-image jobs, eg:

@spiffxp
Copy link
Member

spiffxp commented Jun 4, 2019

I opened kubernetes/kubernetes#78710 to enforce the regex as a gate to promotion to conformance

@spiffxp
Copy link
Member

spiffxp commented Jun 4, 2019

Opened #12887 to strip the regex from as many cargo cults as I could find

@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2019

/close
No complaints since #12887 merged, meant to close this a few weeks ago but forgot

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
No complaints since #12887 merged, meant to close this a few weeks ago but forgot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

randomvariable pushed a commit to randomvariable/test-infra that referenced this issue Oct 16, 2020
Work has been done to clean up the conformance suite such that
no tests are marked as flaky or disruptive, so updating the
documentation so that downstream consumers don't necessarily skip
things. New tests are not eligable for promotion to conformance
if they match any of these tags.

See the following:
kubernetes#9697
kubernetes/kubernetes#62161
kubernetes/kubernetes#76344
kubernetes/kubernetes#78710

Signed-off-by: Naadir Jeewa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/provider/gcp Issues or PRs related to gcp provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

4 participants