Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/small features and refactoring #450

Merged
merged 41 commits into from
Feb 21, 2024
Merged

Feat/small features and refactoring #450

merged 41 commits into from
Feb 21, 2024

Conversation

ChristiaanScheermeijer
Copy link
Collaborator

Description

Features

  • Dynamic GTM tag injection via an environment variable
  • Custom footer text using markdown via an environment variable
  • Initiative for replaceable components
  • Automatic favicon/PWA image generator using a single base icon
  • Dynamic PWA manifest generation

Refactoring

  • Make routing paths static
  • Typing refactoring (.d.ts -> .ts), which revealed some typing problems
  • Update the reload subscriptions mechanism
  • Move controllers to its own directory
  • Move logic from containers/hooks to controllers (progress has been made, but more is planned)

Fixes

  • Prevent a crash when history or favorites fails to load (duplicate IDs)
  • Inline player not supporting TVOD (will always show the paywall)
  • TVOD subscriptions not reloaded on non-SVOD platforms
  • Customer IP not defined when creating a Cleeng order
  • Error when deleting an InPlayer account
  • Unexpected errors (crashes) not showing the ErrorPage
  • Start watching button shown for TVOD items in AVOD platform (no integration configured)

langemike and others added 30 commits January 31, 2024 17:30
@langemike @ChristiaanScheermeijer
feat(project): dynamic gtm snippet
6babace 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@royschut @ChristiaanScheermeijer
refactor(project): make route definitions static and improve url utils
8c0cb9a
@ChristiaanScheermeijer
refactor: refactor typings
1612002
@langemike @ChristiaanScheermeijer
fix(auth): capture error to prevent misleading “wrong combination” error
588f69a 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@langemike @ChristiaanScheermeijer
feat(project): customizable footer through env-var
9d8ff15 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@royschut @ChristiaanScheermeijer
refactor(project): add replaceable components to ui-react
f98e99c
@langemike @ChristiaanScheermeijer
feat(project): favicons in different sizes
a1c6188 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@langemike @ChristiaanScheermeijer
chore(project): dynamic manifest.json
1e3607d 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@ChristiaanScheermeijer
chore: update depcheck
bcfb08b
@royschut @ChristiaanScheermeijer
fix(player): inlineplayer not supporting tvod
bb593e9
@royschut @ChristiaanScheermeijer
fix(user): tvod subscription not reloaded after login for authvod/avod
7de84ae
@royschut @ChristiaanScheermeijer
refactor(payment): fix hasTVODOffers not properly defined
3c021a9
@royschut @ChristiaanScheermeijer
docs(project): update url signing link
7b483b9
@royschut @ChristiaanScheermeijer
fix(payment): subscription offer panel shown for authvod+tvod
d63b056
@royschut @ChristiaanScheermeijer
refactor(payment): simplify useOffers hook
626fa6b
@royschut @ChristiaanScheermeijer
refactor(user): prevent unnecessary subscription calls
7bba6a2
@royschut @ChristiaanScheermeijer
refactor(user): let reloadSubscriptions handle all access modals
5dc0a18
@ChristiaanScheermeijer
refactor: Cleeng and Inplayer account typings
710694d
@langemike @ChristiaanScheermeijer
fix(project): show footer when custom footer is provided
6503267 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@royschut @ChristiaanScheermeijer
fix/checkout bugs
b299bb7
@ChristiaanScheermeijer
fix(account): delete account error
a2885eb
@royschut @ChristiaanScheermeijer
refactor: move controllers and refactor form logic
dbecda4
@ChristiaanScheermeijer
fix: favorites and history validation error
3deabfc
@royschut @ChristiaanScheermeijer
fix(payment): redirect after incorrect couponcode entry
ca71f29
@royschut @ChristiaanScheermeijer
fix(payment): tvod offer not showing in AuthVOD platform
d01d1b7
@royschut @ChristiaanScheermeijer
fix(payment): incorrect couponCode success message
c97c59b
@ChristiaanScheermeijer
fix: root error screen for unexpected errors
320fe44
@langemike @ChristiaanScheermeijer
fix(project): undouble serieIds to prevent crash
ca3d38e
@ChristiaanScheermeijer
fix: hide start watching button in avod platform
86b461f
@langemike
fix: e2e test optimisations and small fixes
b700fbb
@ChristiaanScheermeijer
Copy link
Collaborator Author

Thanks for reviewing this thoroughly @dbudzins, I've implemented most of the requested changes. Let me know what you think!

Have a good weekend 😄

AntonLantukh
AntonLantukh reviewed Feb 19, 2024
View reviewed changes
docs/configuration.md Show resolved Hide resolved
packages/common/src/paths.tsx Show resolved Hide resolved
packages/common/src/paths.tsx Show resolved Hide resolved
platforms/web/tsconfig.json Show resolved Hide resolved
platforms/web/src/containers/Root/Root.tsx Outdated Show resolved Hide resolved
platforms/web/src/containers/AppRoutes/AppRoutes.tsx Show resolved Hide resolved
platforms/web/index.html Show resolved Hide resolved
@AntonLantukh
Copy link
Collaborator

@ChristiaanScheermeijer thank you! I still have some questions regarding continue watching / favorites logic. I will take one more look tomorrow.

@langemike langemike mentioned this pull request Feb 20, 2024
Merged
@royschut royschut mentioned this pull request Feb 20, 2024
Merged
@AntonLantukh
Copy link
Collaborator

@ChristiaanScheermeijer thank you for the changes!

@ChristiaanScheermeijer
Copy link
Collaborator Author

Thanks for reviewing @dbudzins and @AntonLantukh 👍 🙌

@ChristiaanScheermeijer
Copy link
Collaborator Author

@dbudzins @AntonLantukh, can we merge this when you're ready? (the next PRs are already on the way 😄)

@AntonLantukh AntonLantukh merged commit 7ace580 into develop Feb 21, 2024
9 checks passed
@AntonLantukh AntonLantukh deleted the feat/small-features-and-refactoring branch February 21, 2024 18:03
@ChristiaanScheermeijer ChristiaanScheermeijer mentioned this pull request Mar 4, 2024
Closed
8 tasks
@royschut royschut mentioned this pull request Aug 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royschut royschut royschut left review comments

@langemike langemike langemike left review comments

@AntonLantukh AntonLantukh AntonLantukh approved these changes

@dbudzins dbudzins Awaiting requested review from dbudzins dbudzins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristiaanScheermeijer @AntonLantukh @langemike @dbudzins @royschut