Feat/external url improvement #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royschut
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
royschut
force-pushed
the
feat/external-url-improvement
branch
from
e2a26b3
to
c689ece
Compare
royschut
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
ChristiaanScheermeijer
approved these changes
Feb 20, 2024
Base automatically changed from
fix/paypal-await-payment
to
feat/choose-offer-refactor-3
February 20, 2024 19:06
Base automatically changed from
feat/choose-offer-refactor-3
to
feat/sprint-3
February 20, 2024 19:08
ChristiaanScheermeijer
force-pushed
the
feat/external-url-improvement
branch
from
c689ece
to
8346eb4
Compare
ChristiaanScheermeijer
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External URL util improvement
We have a strict util to generate modal URL's that are matched against the
AccountModaltype, so that a non-existing modal url cannot be generated. However, for externally used urls (such as the payment successUrl) we didn't use this yet (as AntonLantukh pointed out here).This PR creates a simple wrapper util so that it is now strict. Also fixed 2 non-existing urls.
Notes
modalURLFromWindowLocation, but it was the best I could think of. Feel free to suggest!