Feat / Render favicons dynamically #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
changed the title
langemike
requested review from
ChristiaanScheermeijer,
MelissaDTH and
royschut
royschut
approved these changes
Feb 20, 2024
| @@ -80,7 +89,7 @@ export default ({ mode, command }: ConfigEnv): UserConfigExport => { | |||
| minify: true, | |||
| inject: { | |||
| tags: [getGoogleVerificationTag(env), fontTags, getGtmTags(env)].flat(), | |||
| data: app, | |||
| data: { ...app, favicons }, | |||
There was a problem hiding this comment.
Not sure, but maybe we want to add favicons to app in the OTTConfig typing?
Edit: I think we don't, but still want to mention it. :)
There was a problem hiding this comment.
I think these 2 are conceptually two separate things. Also adding typing for the favicons (a lengthy string), doesn't feel right to me. I keep it as is ;)
AntonLantukh
approved these changes
Feb 20, 2024
MelissaDTH
changed the title
MelissaDTH
approved these changes
Feb 20, 2024
ChristiaanScheermeijer
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders the favicon tags dynamically. This will make it less prone to errors.
Based on PR feedback: jwplayer#450 (comment)