Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 응원톡 관리 화면에서의 응원톡 전체 조회 #232

Merged
merged 25 commits into from
Sep 26, 2024

Conversation

Jin409
Copy link
Contributor

@Jin409 Jin409 commented Sep 22, 2024

🌍 이슈 번호

📝 구현 내용

스크린샷 2024-09-22 오후 4 52 44

@Jin409 Jin409 changed the title Feat/#218 cheertalks [FEAT] 응원톡 관리 화면에서의 응원톡 전체 조회 Sep 22, 2024
@Jin409 Jin409 self-assigned this Sep 22, 2024
@Jin409 Jin409 marked this pull request as ready for review September 22, 2024 07:53
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어유~ 코멘트를 확인해줘~

Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많았어! 코멘트 남긴건 짚고 넘어가는게 좋을거 같아

Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator 다시 한번 확인해보면 좋을 거 같아

Comment on lines -50 to 53
leagueTeam1.getLeagueTeamPlayers().stream()
leagueTeam1.getLeagueTeamPlayers()
.forEach(gameTeam1::registerLineup);
leagueTeam2.getLeagueTeamPlayers().stream()
leagueTeam2.getLeagueTeamPlayers()
.forEach(gameTeam2::registerLineup);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 내용과는 별개로... Collection.forEach와 Stream.forEach의 차이

@Jin409 Jin409 merged commit 23f1599 into main Sep 26, 2024
1 check passed
@Jin409 Jin409 deleted the feat/#218-cheertalks branch September 26, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 대회에 해당하는 응원톡 전체 조회
2 participants