Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 신고된 응원톡 가리기/가리기 해제 기능 #238

Merged
merged 19 commits into from
Sep 27, 2024
Merged

[FEAT] 신고된 응원톡 가리기/가리기 해제 기능 #238

merged 19 commits into from
Sep 27, 2024

Conversation

Zena0128
Copy link
Contributor

@Zena0128 Zena0128 commented Sep 23, 2024 •
edited
Loading

🌍 이슈 번호

📝 구현 내용

  • 신고된 응원톡을 가리거나 가리기 해제하는 기능 추가

🍀 확인해야 할 부분

  • 인수 테스트의 경우 가려진 응원톡 전체조회, 응원톡 전체조회 기능 머지 후 추가할 예정입니당
  • 문서화 테스트에서 LocalDateTime.now()때문에 충돌나는 거 해결하기 위해 고정된 시간으로 대체했습니다

@Zena0128 Zena0128 self-assigned this Sep 23, 2024
Jin409
Jin409 requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Jin409 Jin409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~

src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/presentation/CheerTalkController.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
hodadako
hodadako requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨어요.💯 리뷰 남긴거 확인하시고 코멘트 남겨주세요.

src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Outdated Show resolved Hide resolved
src/test/java/com/sports/server/command/cheertalk/application/CheerTalkServiceTest.java Outdated Show resolved Hide resolved
hodadako
hodadako reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 남긴건 그렇게 중요한건 아닌거 같아서 승희가 코멘트 남긴 것만 전반적으로 수정하면 좋을 것 같아요

src/test/java/com/sports/server/command/cheertalk/acceptance/CheerTalkAcceptanceTest.java Outdated Show resolved Hide resolved
src/main/java/com/sports/server/command/cheertalk/application/CheerTalkService.java Show resolved Hide resolved
src/docs/asciidoc/api.adoc Outdated Show resolved Hide resolved
@Zena0128 Zena0128 merged commit ed5ef23 into main Sep 27, 2024
1 check passed
@Zena0128 Zena0128 deleted the feat/#231-cheertalk branch September 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jin409 Jin409 Jin409 requested changes

@hodadako hodadako hodadako approved these changes

Assignees

@Zena0128 Zena0128

Labels
feature 정아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zena0128 @hodadako @Jin409