Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 가려진 응원톡 전체 조회하기 #235

Merged
merged 15 commits into from
Sep 29, 2024

Conversation

hodadako
Copy link
Member

🌍 이슈 번호

📝 구현 내용

  • 가려진 응원톡을 대회 별로 조회

🍀 확인해야 할 부분

  • cheer-talk-fixture.sql 에만 [email protected]으로 되어 있길래 이것도 [email protected]으로 수정했어
  • 근데 configureMockJwt()를 @BeforeEach 같은걸로 몰아줄 수는 없을려나.. 매번 치는게 번거롭네

@hodadako
Copy link
Member Author

hodadako commented Sep 25, 2024

@ldk980130 어차피 시간 내기 힘들어보이긴 하지만 아직 미구현된 부분들이 있어서 리뷰 시작하지 않아도 좋아.

#232 완료되고 응답 형식이랑 Validator 클래스 추가하면 내가 그때 다시 알려줄게

Copy link
Contributor

@Zena0128 Zena0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

댓글 하나만 확인해주세요!!

Copy link
Contributor

@Zena0128 Zena0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료했슴당 고생하셨습미다

@hodadako hodadako merged commit ba59e65 into main Sep 29, 2024
1 check passed
@hodadako hodadako deleted the feat/#195-blocked-cheertalk branch September 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 가려진 응원톡 전체 조회
2 participants