-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 가려진 응원톡 전체 조회하기 #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BeforeEach로 조회해오도록 변경
- email을 [email protected]으로 통일 - 이메일 변경에 따른 관련 인수테스트 수정
@ldk980130 어차피 시간 내기 힘들어보이긴 하지만 아직 미구현된 부분들이 있어서 리뷰 시작하지 않아도 좋아. #232 완료되고 응답 형식이랑 |
Zena0128
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
댓글 하나만 확인해주세요!!
src/main/java/com/sports/server/auth/config/SecurityConfig.java
Outdated
Show resolved
Hide resolved
- 권한이 있는 사용자는 MOCK_EMAIL로 통일 - 권한이 없는 사용자 에러메시지 삭제 - 응답 DTO ForManager로 통일
Zena0128
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 완료했슴당 고생하셨습미다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분
@BeforeEach
같은걸로 몰아줄 수는 없을려나.. 매번 치는게 번거롭네