Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2762 part 2 -- fix PCPCombine leap year issue #2766

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Nov 1, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

@CPKalb discovered that the previous PR #2764 still did not work for March of the use case. It did work for January and February. We debugged this together and discovered that the leap year was causing issues due to the way to the last time to look for accumulation data was calculated. This modification uses the valid time minus the total output accumulation as the reference time to compute the number of seconds of a year (input accum). We tested on Derecho with the use case and confirmed that it now works for all months.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Already done (see above)

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes]

We tested using the use case. Writing a useful unit test to make sure this behavior works would involve a lot of work and thought. We could consider adding this in the future, but it is out of the scope for this release.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 11/4/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Nov 1, 2024
@georgemccabe georgemccabe linked an issue Nov 1, 2024 that may be closed by this pull request
24 tasks
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for all months and the output looks as expected

@georgemccabe georgemccabe merged commit fb73473 into develop Nov 4, 2024
75 checks passed
@georgemccabe georgemccabe deleted the bugfix_2762_develop_pcp_followup branch November 4, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix PCPCombine derive mode to properly set field info wrt valid time
2 participants