Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2762 part 2 -- fix PCPCombine leap year issue #2766

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Bugfix #2762 part 2 -- fix PCPCombine leap year issue #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
522f183
remove check if script is master_metplus.py because it has been depre…
georgemccabe Nov 1, 2024
38b8c03
per #2762, fix bug that caused failure depending on valid time relati…
georgemccabe Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metplus/wrappers/pcp_combine_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ def get_accumulation(self, time_info, accum, data_src,
accum_relative = get_relativedelta(accum, 'S')
# using 1 hour for now
smallest_input_accum = min(
[ti_get_seconds_from_relativedelta(lev['amount'], search_time)
[ti_get_seconds_from_relativedelta(lev['amount'], search_time - accum_relative)
for lev in self.c_dict['ACCUM_DICT_LIST']]
)
if smallest_input_accum == 9999999:
Expand Down
6 changes: 0 additions & 6 deletions ush/run_metplus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ def main():
if not config:
return False

# warn if calling master_metplus.py
if basename(__file__) == 'master_metplus.py':
msg = ("master_metplus.py has been renamed to run_metplus.py. "
"This script name will be removed in a future version.")
config.logger.warning(msg)

total_errors = run_metplus(config)

return post_run_cleanup(config, 'METplus', total_errors)
Expand Down