-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Fix PCPCombine derive mode to properly set field info wrt valid time #2762
Comments
… of adding the first field info only
…lativedelta to ensure that the correct number of seconds are used for each search window when using inconsistent time intervals like months or years
* per #2762, change derive mode to add field info for each file instead of adding the first field info only * Per #2762, improve how the accumulation amounts are handling using relativedelta to ensure that the correct number of seconds are used for each search window when using inconsistent time intervals like months or years
This was completed with PR #2764 to be included in METplus v6.0.0-rc1. Additional changes were needed to properly compute the number of seconds to use for an input accum that uses inconsistent time intervals like months or years. The number of seconds is now computed from each search time so it will accurately factor in the correct number of days. This was discovered in discussion #2753. With these changes, the output accum can be set to 30Y and it will correctly build the accumulation without error. |
This came up in discussion #2752
Note that because we are close to the 6.0.0 release and there isn't an immediate need to apply this bugfix to 5.1, we will only be making this change for 6.0.0. If a bugfix for 5.1 is desired, please create a METplus discussion to request it.
Describe the Problem
In derive mode for PCPCombine wrapper, the field info is not added for each file. Instead the first field info if added at the end of the command using the -field argument. This works fine when the field info is the same for each, but the logic breaks when the valid time is used to get the correct NetCDF field from the file.
Expected Behavior
Setting
OBS_PCP_COMBINE_INPUT_LEVELS ="({valid?fmt=%Y%m%d_%H%M%S},*,*)"
should properly substitute the valid time for each "input accumulation" per file instead of once at the end.Environment
Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)
To Reproduce
Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2783544
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
Complete the issue definition above, including the Time Estimate and Funding Source.
Fork this repository or create a branch of main_<Version>.
Branch name:
bugfix_<Issue Number>_main_<Version>_<Description>
Fix the bug and test your changes.
Add/update log messages for easier debugging.
Add/update unit tests.
Add/update documentation.
Add any new Python packages to the METplus Components Python Requirements table.
Push local changes to GitHub.
Submit a pull request to merge into main_<Version>.
Pull request:
bugfix <Issue Number> main_<Version> <Description>
Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next bugfix version
Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
Iterate until the reviewer(s) accept and merge your changes.
Delete your fork or branch.
Complete the steps above to fix the bug on the develop branch.
Branch name:
bugfix_<Issue Number>_develop_<Description>
Pull request:
bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
Close this issue.
The text was updated successfully, but these errors were encountered: