Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

71 open bbox filter gtfs bbox to be a polygon #143

Merged
merged 5 commits into from
Sep 20, 2023
Merged

71 open bbox filter gtfs bbox to be a polygon #143

merged 5 commits into from
Sep 20, 2023

Conversation

r-leyshon
Copy link
Contributor

Description

Fixes #71, fixes #63

Motivation and Context

  • bbox_filter_osm accepts either list or geodataframe.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • test added for bbox list or bbox gdf.

Test configuration details:

  • OS: macos
  • Python version: 3.9.13
  • Java version: openjdk 11.0.19 2023-04-18 LTS
  • Python management system: pip

Advice for reviewer

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

@r-leyshon r-leyshon added the enhancement New feature or request label Sep 20, 2023
@r-leyshon r-leyshon added this to the sprint 4 End milestone Sep 20, 2023
@r-leyshon r-leyshon linked an issue Sep 20, 2023 that may be closed by this pull request
Open bbox_filter_gtfs() bbox to be a polygon #71
Closed
@CBROWN-ONS CBROWN-ONS self-assigned this Sep 20, 2023
CBROWN-ONS
CBROWN-ONS requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@CBROWN-ONS CBROWN-ONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed. These mostly relate to type defences and paths. Overall functionality of the function is solid and works well.

src/transport_performance/gtfs/gtfs_utils.py Outdated Show resolved Hide resolved
src/transport_performance/gtfs/gtfs_utils.py Outdated Show resolved Hide resolved
src/transport_performance/gtfs/gtfs_utils.py Outdated Show resolved Hide resolved
src/transport_performance/gtfs/gtfs_utils.py Show resolved Hide resolved
@r-leyshon
Copy link
Contributor Author

@CBROWN-ONS feedback implemented - many thanks, this module is a lot neater and standardised with our defence utilities.

@CBROWN-ONS CBROWN-ONS merged commit e52d5ca into dev Sep 20, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
@CBROWN-ONS
Merge pull request #143 from datasciencecampus/71-open-bbox_filter_gt…
ddd4d0d 
…fs-bbox-to-be-a-polygon

71 open bbox filter gtfs bbox to be a polygon e52d5ca
@r-leyshon r-leyshon deleted the 71-open-bbox_filter_gtfs-bbox-to-be-a-polygon branch September 20, 2023 15:17
@r-leyshon r-leyshon mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBROWN-ONS CBROWN-ONS CBROWN-ONS approved these changes

Assignees

@CBROWN-ONS CBROWN-ONS

Labels
enhancement New feature or request
Projects
None yet
Milestone
sprint 4 End
Development

Successfully merging this pull request may close these issues.

Open bbox_filter_gtfs() bbox to be a polygon Change default unit argument from "m" to "km"
2 participants
@r-leyshon @CBROWN-ONS