Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default unit argument from "m" to "km" #63

Closed
ethan-moss opened this issue Aug 16, 2023 · 2 comments · Fixed by #143 or #158
Closed

Change default unit argument from "m" to "km" #63

ethan-moss opened this issue Aug 16, 2023 · 2 comments · Fixed by #143 or #158
Assignees
Labels
GTFS needs triage technical debt A better way is available. Fix later approach has been adopted.
Milestone

Comments

@ethan-moss
Copy link
Collaborator

Description of the Feature to be Added

The GtfsInstance class has a default argument of "m" for the GTFS units. However, this is not very common - "km" is more widely adopted and would be a better choice as the default argument to help protect against potential unforeseen errors.

(OPTIONAL) Suggested Implementations

Change the default unit argument from "m" to "km" throughout the class.

Additional context

Examples of Km units being used can be provided if needed.

@ethan-moss ethan-moss added needs triage technical debt A better way is available. Fix later approach has been adopted. GTFS labels Aug 16, 2023
@ethan-moss
Copy link
Collaborator Author

Closing since performance gains would be too minor and unable to trust the stability of the end point.

@r-leyshon r-leyshon reopened this Sep 20, 2023
@r-leyshon r-leyshon added this to the sprint 4 End milestone Sep 20, 2023
@r-leyshon r-leyshon self-assigned this Sep 20, 2023
@r-leyshon r-leyshon reopened this Oct 3, 2023
@r-leyshon
Copy link
Contributor

Reopening as realised this was not completed with #143 (my mistake, that resolved the default units value in the OSM module, not GTFS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS needs triage technical debt A better way is available. Fix later approach has been adopted.
Projects
None yet
2 participants