Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open bbox_filter_gtfs() bbox to be a polygon #71

Closed
ethan-moss opened this issue Aug 17, 2023 · 1 comment · Fixed by #143
Closed

Open bbox_filter_gtfs() bbox to be a polygon #71

ethan-moss opened this issue Aug 17, 2023 · 1 comment · Fixed by #143
Assignees
Labels
GTFS needs triage technical debt A better way is available. Fix later approach has been adopted.
Milestone

Comments

@ethan-moss
Copy link
Collaborator

Description of the Feature to be Added

Open bbox_filter_gtfs() bbox to be a polygon instead of a list:

  • GTFS kit docs suggest the restrict_to_area() method accepts a gdf of polygons. So we could open up this function to accept a polygon as an input (instead of a BBOX). This would then be the same input type as the RasterPop module.
  • This would also the work better with the urban_centre module, which returns shapely polygons.
@ethan-moss ethan-moss added needs triage technical debt A better way is available. Fix later approach has been adopted. GTFS labels Aug 17, 2023
@r-leyshon
Copy link
Contributor

Sounds like a useful feature @ethan-moss , though could we have a list or a polygon? Common pattern of mine is to pull a bbox csv of klokantech etc and paste it into a list.

@r-leyshon r-leyshon added this to the sprint 4 End milestone Sep 20, 2023
@r-leyshon r-leyshon linked a pull request Sep 20, 2023 that will close this issue
11 tasks
@r-leyshon r-leyshon self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS needs triage technical debt A better way is available. Fix later approach has been adopted.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants