Remove loading state from modal if the payment preview fails #9735
Conversation
|
Demo starting at https://ubuntu-com-9735.demos.haus |
static/js/src/ua-payment-modal.js
Outdated
| }) | ||
| .catch((error) => { | ||
| modal.classList.remove("is-processing"); | ||
| setOrderTotals(null, false, currentTransaction, modal); |
There was a problem hiding this comment.
Shouldn't we display an error to the user when this happens?
There was a problem hiding this comment.
I'm not sure. my understanding of the situation is correct, it fails when a payment method is missing from their account. But going through the modal will create a new payment method and attach it to the account.
I'm not sure what the error message could be for it to make sense to the user and if going through the flow normally fixes it then I find it reasonable to let it fail silently?
@alnvdl Do you think it makes sense?
There was a problem hiding this comment.
If this seamlessly gets the user back on track then that is fine.
| .catch((error) => { | ||
| modal.classList.remove("is-processing"); | ||
| setOrderTotals(null, false, currentTransaction, modal); | ||
| console.error(error); |
There was a problem hiding this comment.
Can you report this issue to sentry?
There was a problem hiding this comment.
If I'm not mistaken we don't have a sentry client for the frontend. And I believe we log any failed backend (flask) call. So this would be reported to sentry as a failed /advantage/subscribe/preview call.
Do you think it would be worth adding Sentry to the front end as well? I think it could be useful. It was first mentioned here canonical/jp.ubuntu.com#131 and then later on here to help us debug unknown errors in the shop https://app.zenhub.com/workspaces/web--ubuntu-clan-5931746dba512f05402b61f6/issues/canonical-web-and-design/ubuntu.com/9543
I'm willing to do it but I think it would be a different ticket
There was a problem hiding this comment.
We do catch those in the back-end already. It might be redundant to add them in the front-end too.
There was a problem hiding this comment.
We will have a huge set of front-end only failures that do not result in errors in the backend. So I think it's worth it but agree is a separate issue.
albertkol
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Done
QA
This is a bit tricky to QA
Here is one way: https://app.zenhub.com/workspaces/web--ubuntu-clan-5931746dba512f05402b61f6/issues/canonical-web-and-design/ubuntu.com/9724
Another way would be to fetch this branch and modify the call to purchase preview so it always returns an error and see that the modal still loads.
Important
This addresses https://github.com/canonical-web-and-design/web-squad/issues/4087 and should remove the bug for users but I don't believe this fixes the root cause of the payment preview failing.