Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading state from modal if the payment preview fails #9735

Merged
merged 3 commits into from
May 11, 2021
Merged

Remove loading state from modal if the payment preview fails #9735

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561379f
Remove loading state from modal if the paymentpreview fails
ClementChaumel May 11, 2021
d3f1a50
Present user with subtotal if the preview fails
ClementChaumel May 11, 2021
f40f2e2
Set the correct value as the total if the preview fails gracefully
ClementChaumel May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions static/js/src/ua-payment-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,14 +401,21 @@ function applyLoggedInPurchaseTotals() {
currentTransaction.accountId,
currentTransaction.products,
currentTransaction.previousPurchaseId
).then((purchasePreview) => {
currentTransaction.total = purchasePreview.total;
currentTransaction.tax = purchasePreview.taxAmount;
modal.classList.remove("is-processing");
setOrderTotals(country, vatApplicable, purchasePreview, modal);
});
)
.then((purchasePreview) => {
currentTransaction.total = purchasePreview.total;
currentTransaction.tax = purchasePreview.taxAmount;
modal.classList.remove("is-processing");
setOrderTotals(country, vatApplicable, purchasePreview, modal);
})
.catch((error) => {
modal.classList.remove("is-processing");
setOrderTotals(null, false, currentTransaction, modal);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we display an error to the user when this happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. my understanding of the situation is correct, it fails when a payment method is missing from their account. But going through the modal will create a new payment method and attach it to the account.
I'm not sure what the error message could be for it to make sense to the user and if going through the flow normally fixes it then I find it reasonable to let it fail silently?

@alnvdl Do you think it makes sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this seamlessly gets the user back on track then that is fine.

console.error(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you report this issue to sentry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken we don't have a sentry client for the frontend. And I believe we log any failed backend (flask) call. So this would be reported to sentry as a failed /advantage/subscribe/preview call.
Do you think it would be worth adding Sentry to the front end as well? I think it could be useful. It was first mentioned here canonical/jp.ubuntu.com#131 and then later on here to help us debug unknown errors in the shop https://app.zenhub.com/workspaces/web--ubuntu-clan-5931746dba512f05402b61f6/issues/canonical-web-and-design/ubuntu.com/9543

I'm willing to do it but I think it would be a different ticket

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do catch those in the back-end already. It might be redundant to add them in the front-end too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have a huge set of front-end only failures that do not result in errors in the backend. So I think it's worth it but agree is a separate issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to this: #9543

});
})
.catch((error) => {
modal.classList.remove("is-processing");
console.error(error);
});
}
Expand Down