Add another flavor of permission api #15609
Open
+8,723
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 28m total CI duration on this PR
|
This was referenced Dec 16, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
16346c7 to
fc085a0
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
be4ea04 to
46ddd6f
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
fc085a0 to
6a2e87a
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
46ddd6f to
0ee1c8c
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
6a2e87a to
a5e92c0
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
0ee1c8c to
851da1d
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
a5e92c0 to
60ce91a
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
2 times, most recently
from
e06ec0c to
dd67295
Compare
runtian-zhou
changed the base branch from
10-09-create_benchmark
to
12-17-feature_gate_permissioned_signer
8 tasks
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+618
to
+642
| if (perm.key != perm_key) { | ||
| return false | ||
| }; |
There was a problem hiding this comment.
The generic type parameter PermKey only requires copy + drop + store abilities, but the code uses the != operator which may not be supported for all possible types satisfying these constraints. To ensure type safety, consider either:
- Adding
drop + copy + store + has[std::cmp::Eq]as the ability constraint forPermKey, or - Using a dedicated comparison function that's guaranteed to work for the intended key types
This will prevent potential runtime errors when comparing complex key types that don't implement equality comparison.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
6494f73 to
2bd4613
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
dd67295 to
287f491
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
2bd4613 to
472be55
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
287f491 to
9bb1d3b
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
472be55 to
18a8c9a
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
9bb1d3b to
84b19ea
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
18a8c9a to
015bf33
Compare
runtian-zhou
force-pushed
the
12-15-add_another_flavor_of_permission_api
branch
from
84b19ea to
646097a
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
015bf33 to
f9ea87a
Compare
runtian-zhou
force-pushed
the
01-10-create_object_with_permissioned_signer
branch
2 times, most recently
from
629e352 to
83738a4
Compare
22 tasks
runtian-zhou
force-pushed
the
01-10-create_object_with_permissioned_signer
branch
8 times, most recently
from
f2d1cc7 to
154c5d2
Compare
runtian-zhou
requested review from
msmouse,
lightmark,
grao1991,
junkil-park,
alinush,
davidiw,
movekevin and
wrwg
as code owners
runtian-zhou
force-pushed
the
01-10-create_object_with_permissioned_signer
branch
from
154c5d2 to
7fce8b6
Compare
runtian-zhou
force-pushed
the
01-10-create_object_with_permissioned_signer
branch
5 times, most recently
from
2b01fae to
75508ff
Compare
Base automatically changed from
01-10-create_object_with_permissioned_signer
to
09-09-add_perimission_checks_to_object
January 15, 2025 22:06
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
eb4b8f1 to
e4a9607
Compare
Base automatically changed from
09-09-add_perimission_checks_to_object
to
main
January 16, 2025 01:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist