-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[object] Add permissioned checks to object #14582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 45m total CI duration on this PR
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 10, 2024 17:29
da28781
to
006ad4c
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 10, 2024 17:30
381be20
to
6a1fe6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-04-add_permission_check_to_account #14582 +/- ##
======================================================================
Coverage 59.4% 59.4%
======================================================================
Files 857 857
Lines 210762 210762
======================================================================
Hits 125197 125197
Misses 85565 85565 ☔ View full report in Codecov by Sentry. |
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 12, 2024 01:50
006ad4c
to
ef7abd3
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 12, 2024 01:50
6a1fe6d
to
9037ce3
Compare
This was referenced Sep 12, 2024
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 17, 2024 05:09
ef7abd3
to
c38c2dd
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 17, 2024 05:09
9037ce3
to
843150a
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 17, 2024 21:23
c38c2dd
to
95b6704
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 17, 2024 21:23
843150a
to
33a73d7
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 18, 2024 06:23
95b6704
to
7394967
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 18, 2024 06:23
33a73d7
to
9123ceb
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 18, 2024 17:52
7394967
to
a091794
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 18, 2024 17:52
9123ceb
to
206e782
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 19, 2024 00:35
a091794
to
67163ae
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 19, 2024 00:35
206e782
to
9c81c83
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
September 19, 2024 08:09
67163ae
to
f10a3b3
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
September 19, 2024 08:09
9c81c83
to
75362c4
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
October 4, 2024 20:56
f10a3b3
to
5c9396f
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
October 4, 2024 20:57
75362c4
to
86c07b1
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
October 5, 2024 01:54
5c9396f
to
9935539
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
October 5, 2024 01:54
86c07b1
to
0573a7b
Compare
runtian-zhou
force-pushed
the
09-04-add_permission_check_to_account
branch
from
October 5, 2024 02:25
9935539
to
b927c02
Compare
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
October 5, 2024 02:25
0573a7b
to
6a446be
Compare
This comment has been minimized.
This comment has been minimized.
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
January 15, 2025 20:20
b45959f
to
4dbfcfa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
January 15, 2025 21:12
4dbfcfa
to
5c551bf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Create object with permissioned signer * Update permissioned_signer.move * Update permissioned_signer.move
runtian-zhou
force-pushed
the
09-09-add_perimission_checks_to_object
branch
from
January 15, 2025 23:44
eb4b8f1
to
e4a9607
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds permissioned signer support for object transfers and token/collection mutations in the Aptos Framework. This change introduces new permission types and validation checks to ensure only authorized signers can perform transfers and mutations on objects, tokens and collections.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added new test cases in object.move and aptos_token.move to verify permissioned signer functionality for transfers and mutations.
Key Areas to Review
Checklist