-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission for framework #14605
permission for framework #14605
Conversation
⏱️ 3h 36m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-09-add_perimission_checks_to_object #14605 +/- ##
=========================================================================
+ Coverage 59.4% 60.0% +0.6%
=========================================================================
Files 857 857
Lines 210762 210762
=========================================================================
+ Hits 125197 126586 +1389
+ Misses 85565 84176 -1389 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the initialization with intent code?
9037ce3
to
843150a
Compare
b2c0a3d
to
8ab6836
Compare
843150a
to
33a73d7
Compare
8ab6836
to
fe7cd59
Compare
33a73d7
to
9123ceb
Compare
fe7cd59
to
d48d186
Compare
9123ceb
to
206e782
Compare
d48d186
to
3c1467e
Compare
206e782
to
9c81c83
Compare
3c1467e
to
ac81f59
Compare
9c81c83
to
75362c4
Compare
ac81f59
to
2695494
Compare
daea4f8
to
76ad6f0
Compare
729cd2a
to
638ddbb
Compare
a1b3941
to
9d5b2ff
Compare
99580a8
to
9b13784
Compare
9d5b2ff
to
a37e257
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a37e257
to
bb04684
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bb04684
to
0fb869e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0fb869e
to
174451f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Description
Implement checks for all framework related privilege operations.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added relevant tests.
Key Areas to Review
Whether there's any priviledged operation need to be gated.
Checklist