Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission for framework #14605

Merged
merged 2 commits into from
Jan 16, 2025
Merged

permission for framework #14605

merged 2 commits into from
Jan 16, 2025

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Sep 12, 2024

Description

Implement checks for all framework related privilege operations.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Added relevant tests.

Key Areas to Review

Whether there's any priviledged operation need to be gated.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 12, 2024

⏱️ 3h 36m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 27m 🟥🟩
rust-move-unit-coverage 20m 🟩
rust-move-unit-coverage 19m 🟩
rust-move-unit-coverage 18m 🟩
rust-move-unit-coverage 14m 🟩
rust-targeted-unit-tests 14m
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 11m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-unit-coverage 10m 🟩
rust-move-tests 10m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-unit-coverage 9m 🟩
rust-move-tests 9m 🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-cargo-deny 4m 2m +126%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.0%. Comparing base (2431b7b) to head (e4239a8).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           09-09-add_perimission_checks_to_object   #14605     +/-   ##
=========================================================================
+ Coverage                                    59.4%    60.0%   +0.6%     
=========================================================================
  Files                                         857      857             
  Lines                                      210762   210762             
=========================================================================
+ Hits                                       125197   126586   +1389     
+ Misses                                      85565    84176   -1389     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the initialization with intent code?

@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9037ce3 to 843150a Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from b2c0a3d to 8ab6836 Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 843150a to 33a73d7 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 8ab6836 to fe7cd59 Compare September 17, 2024 21:24
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 33a73d7 to 9123ceb Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from fe7cd59 to d48d186 Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9123ceb to 206e782 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from d48d186 to 3c1467e Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 206e782 to 9c81c83 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 3c1467e to ac81f59 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9c81c83 to 75362c4 Compare September 19, 2024 08:09
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from ac81f59 to 2695494 Compare September 19, 2024 08:09
@rahxephon89 rahxephon89 force-pushed the 09-11-permission_for_framework branch from daea4f8 to 76ad6f0 Compare October 1, 2024 20:12
@rahxephon89 rahxephon89 changed the base branch from 09-09-add_perimission_checks_to_object to main October 1, 2024 20:12
@runtian-zhou runtian-zhou marked this pull request as ready for review October 4, 2024 20:46
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 729cd2a to 638ddbb Compare October 4, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from a1b3941 to 9d5b2ff Compare January 16, 2025 03:30
Base automatically changed from asset_permission to main January 16, 2025 04:34
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 9d5b2ff to a37e257 Compare January 16, 2025 04:40
@runtian-zhou runtian-zhou enabled auto-merge (squash) January 16, 2025 04:40

This comment has been minimized.

This comment has been minimized.

@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from a37e257 to bb04684 Compare January 16, 2025 04:58

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from bb04684 to 0fb869e Compare January 16, 2025 05:42

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 0fb869e to 174451f Compare January 16, 2025 06:45

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 174451f62ba1b90f9d59bccfb729ce74133cb075

Compatibility test results for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 174451f62ba1b90f9d59bccfb729ce74133cb075 (PR)
1. Check liveness of validators at old version: f69dc31b0f674662b6bfa941dc7eee9ce9035e29
compatibility::simple-validator-upgrade::liveness-check : committed: 16277.71 txn/s, latency: 1958.09 ms, (p50: 1900 ms, p70: 1900, p90: 2100 ms, p99: 2700 ms), latency samples: 524600
2. Upgrading first Validator to new version: 174451f62ba1b90f9d59bccfb729ce74133cb075
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5036.03 txn/s, latency: 6133.14 ms, (p50: 6900 ms, p70: 7400, p90: 7600 ms, p99: 7800 ms), latency samples: 99240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5024.71 txn/s, latency: 6816.55 ms, (p50: 7600 ms, p70: 7600, p90: 7800 ms, p99: 7800 ms), latency samples: 176760
3. Upgrading rest of first batch to new version: 174451f62ba1b90f9d59bccfb729ce74133cb075
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4828.16 txn/s, latency: 6386.51 ms, (p50: 7200 ms, p70: 7700, p90: 8000 ms, p99: 8200 ms), latency samples: 97020
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4736.62 txn/s, latency: 7250.24 ms, (p50: 8000 ms, p70: 8200, p90: 8400 ms, p99: 8600 ms), latency samples: 169860
4. upgrading second batch to new version: 174451f62ba1b90f9d59bccfb729ce74133cb075
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9059.09 txn/s, latency: 3313.06 ms, (p50: 3900 ms, p70: 4000, p90: 4300 ms, p99: 4500 ms), latency samples: 164060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8991.15 txn/s, latency: 3817.28 ms, (p50: 4000 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 296460
5. check swarm health
Compatibility test for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 174451f62ba1b90f9d59bccfb729ce74133cb075 passed
Test Ok

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 174451f62ba1b90f9d59bccfb729ce74133cb075

two traffics test: inner traffic : committed: 14875.71 txn/s, submitted: 14877.34 txn/s, expired: 1.63 txn/s, latency: 2660.96 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3900 ms), latency samples: 5656080
two traffics test : committed: 99.98 txn/s, latency: 1294.95 ms, (p50: 1300 ms, p70: 1300, p90: 1400 ms, p99: 1600 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.595, avg: 1.499", "ConsensusProposalToOrdered: max: 0.292, avg: 0.289", "ConsensusOrderedToCommit: max: 0.330, avg: 0.319", "ConsensusProposalToCommit: max: 0.619, avg: 0.607"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.04s no progress at version 31191 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 2394711 (avg 0.53s) [limit 16].
Test Ok

@runtian-zhou runtian-zhou merged commit 2798d4e into main Jan 16, 2025
43 of 46 checks passed
@runtian-zhou runtian-zhou deleted the 09-11-permission_for_framework branch January 16, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants