Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Use a stable UT instead of unstable IT(test_global_runtime_filter_olap_table_sink) #44519

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[Test] Use a stable UT instead of unstable IT(test_global_runtime_filter_olap_table_sink) #44519

merged 1 commit into from
Apr 22, 2024

Conversation

satanson
Copy link
Contributor

@satanson satanson commented Apr 22, 2024 •
edited
Loading

Why I'm doing:

Integrated Test test_global_runtime_filter_olap_table_sink is unstable, often destructs CI.

What I'm doing:

Remove this IT, use a stable UT instead.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 936cdd1 into StarRocks:main Apr 22, 2024
46 of 48 checks passed
@satanson
Copy link
Contributor Author

@Mergifyio backport branch-3.3

@satanson
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@satanson
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.1

@satanson
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.0

@satanson
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@satanson @mergify
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
792c3d3 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)
@mergify mergify bot mentioned this pull request Apr 22, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@satanson @mergify
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
26aa803 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)

# Conflicts:
#	test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
#	test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@satanson @mergify
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
65280a7 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/TPCDSCoordTest.java
#	test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
#	test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@satanson @mergify
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
cd5bab5 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/TPCDSCoordTest.java
#	test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
#	test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@satanson @mergify
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
809aa2f 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/TPCDSCoordTest.java
#	test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
#	test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
42 tasks
satanson added a commit that referenced this pull request Apr 22, 2024
@satanson
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
70004d2 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 22, 2024
Merged
42 tasks
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
ca0d5b8 
…ter_olap_table_sink) (StarRocks#44519)

Signed-off-by: satanson <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 22, 2024
@mergify @satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
3e22e6f 
…r_olap_table_sink) (backport #44519) (#44537)

Co-authored-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 22, 2024
Merged
42 tasks
satanson added a commit that referenced this pull request Apr 22, 2024
@satanson
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
9e417d7 
…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
655d13b 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 22, 2024
Merged
42 tasks
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
23d07a9 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[Test] Use a stable UT instead of unstable IT(test_global_runtime_fil…
fa08168 
…ter_olap_table_sink) (StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
c945ebe 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 22, 2024
Merged
42 tasks
kangkaisen pushed a commit that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
38644c0 
…r_olap_table_sink) (backport #44519) (#44544)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
e24ae3d 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
9bdb1db 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
4b76120 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
dirtysalt pushed a commit that referenced this pull request Apr 22, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_fiter…
b935829 
…_olap_table_sink) (backport #44519) (#44549)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
9359ff0 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
a9b5b31 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
731688d 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
ZiheLiu pushed a commit that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
d7d1a63 
…r_olap_table_sink) (backport #44519) (#44550)

Signed-off-by: satanson <[email protected]>
satanson added a commit to satanson/starrocks that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
6b366d9 
…r_olap_table_sink) (backport StarRocks#44519)

Signed-off-by: satanson <[email protected]>
ZiheLiu pushed a commit that referenced this pull request Apr 23, 2024
@satanson
[UT] Use a stable UT instead of unstable IT(test_global_runtime_filte…
c511d68 
…r_olap_table_sink) (backport #44519) (#44552)

Signed-off-by: satanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@satanson satanson

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged title needs [type]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satanson @silverbullet233 @kangkaisen