Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Use a stable UT instead of unstable IT(test_global_runtime_filter_olap_table_sink) (backport #44519) #44541

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2024

Why I'm doing:

Integrated Test test_global_runtime_filter_olap_table_sink is unstable, often destructs CI.

What I'm doing:

Remove this IT, use a stable UT instead.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44519 done by [Mergify](https://mergify.com). ## Why I'm doing: Integrated Test test_global_runtime_filter_olap_table_sink is unstable, often destructs CI.

What I'm doing:

Remove this IT, use a stable UT instead.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ter_olap_table_sink) (#44519)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 936cdd1)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/TPCDSCoordTest.java
#	test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
#	test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink
Copy link
Contributor Author

mergify bot commented Apr 22, 2024

Cherry-pick of 936cdd1 has failed:

On branch mergify/bp/branch-2.5/pr-44519
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 936cdd1c17.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/qe/TPCDSCoordTest.java
	deleted by them: test/sql/test_global_runtime_filter_olap_table_sink/R/test_global_runtime_filter_olap_table_sink
	deleted by them: test/sql/test_global_runtime_filter_olap_table_sink/T/test_global_runtime_filter_olap_table_sink

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Apr 22, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Apr 22, 2024
@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-44519 branch April 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant