Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] Use a stable UT instead of unstable IT(test_global_runtime_filter_olap_table_sink) (backport #44519) #44552

Conversation

satanson
Copy link
Contributor

@satanson satanson commented Apr 22, 2024

Why I'm doing:

Integrated Test test_global_runtime_filter_olap_table_sink is unstable, often destructs CI.

What I'm doing:

Remove this IT, use a stable UT instead.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44519 done by [Mergify](https://mergify.com). ## Why I'm doing: Integrated Test test_global_runtime_filter_olap_table_sink is unstable, often destructs CI.

What I'm doing:

Remove this IT, use a stable UT instead.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@satanson satanson force-pushed the branch-2.5_test_global_runtime_filter_olap_table_sink_stable branch 3 times, most recently from a9b5b31 to 731688d Compare April 23, 2024 02:10
@satanson satanson force-pushed the branch-2.5_test_global_runtime_filter_olap_table_sink_stable branch from 731688d to 6b366d9 Compare April 23, 2024 02:12
@ZiheLiu ZiheLiu merged commit c511d68 into StarRocks:branch-2.5 Apr 23, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants