GENIE Rockbox Dirt Workflow #203

etyley · 2021-10-28T11:05:24Z

This PR adds fcls and filters required to generate dirt interactions using the GENIEHelper RockBox configuration, fixing #176.

The structure of the added code is as follows:

Gen:

Update genie_sbnd to contain the rockbox configuration
Add prodgenie_rockbox_sbnd as a base fcl for generating events. This saves any event with either a interaction in the TPC volume or a dirt interaction that deposits >100 MeV in the TPC during the beam window
Add prodgenie_rockbox_intrnue_sbnd version of this fcl for NuE only events
Add prodoverlay_corsika_cosmics_proton_genie_rockbox_(intrnue_)sbnd.fcl to add CORSIKA overlay to the GENIE fcls

G4:

Create a new sbnd_merge_overlay_sim_sources to manage the merging of the largeant instances
Add g4_dirt_filter.fcl to run G4 without largeant as that is run in the gen stage of the rockbox fcls
Add g4_dirt_overlay_filter.fcl to run largeant over CORSIKA and merge the collection with the GENIE largeant collection before running the remained of standard G4
Add sce versions of both of the above
Ideally both workflows would use the same G4 but that is not possible due to ongoing issues with the new larG4: https://cdcvs.fnal.gov/redmine/projects/larsoft/wiki/ReleaseNotes093500#Known-issues. Once this is addressed largeantCosmic and the merging should be moved to the prodoverlay_rockbox fcls so they can use the g4_dirt_filter rather than having their own fcl.

Filters:

Add new SimEnergyDepFakeTriggerFilter to utilise the SimEnergyDeposit produced by the refactored larG4 to check the amount of energy deposited in the detector during the beam spill time
Create a new sbnd_tpc_gennufilter filter to check if a neutrino interaction occurs inside the TPC volume
Add split_tpc_nu fcl to run over input files and split into two output streams for those with/without a TPC interation.

As of v09_35_01 the relevant LArSoft changes have been merged and the necessary addition to sbnd_data is done, so this PR is ready for review

… any previous dirt fcl

jzennamo · 2021-11-05T16:21:57Z

sbndcode/Filters/fcls/simenergydepfaketriggerfilter.fcl

+  # Select the beam spill time to match that in sbnd_filtergenintime
+  BeamTimeMin:    -0.2        # Minimum time of beam window [us]
+  BeamTimeMax:     1.9        # Maximum time of beam window [us]
+  EnergyDeposit:   100        # Minimum energy deposit in TPC for trigger [MeV]


In the future we should think if this is the best value for this, for now I am happy to proceed but we should open an issue to verify this is the optimal energy cut.

I agree, I will do that once this has been merged.

jzennamo

This is excellent! One question before I formally approve, has this been tested all the way through reco2 to make sure the full end-to-end workflows work with these events?

etyley · 2021-11-05T16:28:17Z

I have tested this end-to-end with an older release and am currently re-running through the validation now that everything has been updated to v09_35_01

jzennamo · 2021-11-05T16:31:22Z

awesome, that is sufficient for me, but let us know how the v09_35_01 test goes!

marcodeltutto

Thanks very much @etyley! Looks great

marcodeltutto · 2021-11-05T20:08:39Z

sbndcode/JobConfigurations/standard/g4/g4_dirt_overlay_filter.fcl

+outputs.out1.outputCommands: [ "keep *_*_*_*"
+                             , "drop *_largeantnu_*_*"
+                             , "drop *_largeantcosmic_*_*"
+                             ]


If PR #206 is approved, do you mind dropping the larg4 SimEnergyDeposits here too? Thanks!

@etyley #206 has now been approved and merged, so you can now update this to also drop these products

@pgreen135 Done!

pgreen135 · 2021-11-08T13:57:42Z

trigger build

FNALbuild · 2021-11-08T13:58:52Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2021-11-08T13:59:04Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2021-11-08T14:23:04Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2021-11-08T14:49:32Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

pgreen135

CI's look good, differences are unrelated to this.

pgreen135 · 2021-11-10T14:10:40Z

trigger build

FNALbuild · 2021-11-10T14:12:25Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2021-11-10T14:12:29Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2021-11-10T14:38:23Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2021-11-10T14:38:49Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

marcodeltutto mentioned this pull request Oct 28, 2021

Cosmic InTime Workflow with Refactored LArG4 #192

Merged

etyley linked an issue Oct 28, 2021 that may be closed by this pull request

Dirt Workflow #176

Closed

etyley added 9 commits November 5, 2021 08:43

First commit of GENIE rockbox fcls for simulating dirt

2cc8d12

Create split output rockbox fcl

76cf88c

Update filters for rockbox

f7dc6e9

First commit of working prodoverlay rockbox workflow

0d8609d

Add comments to rockbox overlay fcls

3f6dfef

Tidy merge sim sources fcls for dirt overlay samples

68bce7c

Tidy rockbox fcls

aa6f04b

Update SimEnergyDep Filter

d54c47b

Update path of GENIE rockbox max path length

9016cd4

etyley force-pushed the feature/etyley_dirt branch from 2aafc41 to 9016cd4 Compare November 5, 2021 13:56

wesketchum assigned etyley Nov 5, 2021

etyley added 2 commits November 5, 2021 10:41

Move splitting dirt/tpc output to dedicated fcl that can be run after…

ee4f695

… any previous dirt fcl

Add sce version of dirt g4 fcls

4232677

etyley marked this pull request as ready for review November 5, 2021 16:05

etyley requested review from marcodeltutto and jzennamo November 5, 2021 16:05

jzennamo reviewed Nov 5, 2021

View reviewed changes

jzennamo approved these changes Nov 5, 2021

View reviewed changes

Update split_tpc_nu output patterns to retain the input file names

ae31557

marcodeltutto approved these changes Nov 5, 2021

View reviewed changes

pgreen135 approved these changes Nov 8, 2021

View reviewed changes

Drop more products in dirt workflow inkeeping with PR 206

cd280f3

pgreen135 merged commit 13e1d6d into develop Nov 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GENIE Rockbox Dirt Workflow #203

GENIE Rockbox Dirt Workflow #203

etyley commented Oct 28, 2021 •

edited

Loading

jzennamo Nov 5, 2021

etyley Nov 5, 2021

jzennamo left a comment

etyley commented Nov 5, 2021

jzennamo commented Nov 5, 2021

marcodeltutto left a comment

marcodeltutto Nov 5, 2021

pgreen135 Nov 9, 2021

etyley Nov 10, 2021

pgreen135 commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

pgreen135 left a comment

pgreen135 commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

GENIE Rockbox Dirt Workflow #203

GENIE Rockbox Dirt Workflow #203

Conversation

etyley commented Oct 28, 2021 • edited Loading

Gen:

G4:

Filters:

jzennamo Nov 5, 2021

Choose a reason for hiding this comment

etyley Nov 5, 2021

Choose a reason for hiding this comment

jzennamo left a comment

Choose a reason for hiding this comment

etyley commented Nov 5, 2021

jzennamo commented Nov 5, 2021

marcodeltutto left a comment

Choose a reason for hiding this comment

marcodeltutto Nov 5, 2021

Choose a reason for hiding this comment

pgreen135 Nov 9, 2021

Choose a reason for hiding this comment

etyley Nov 10, 2021

Choose a reason for hiding this comment

pgreen135 commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

FNALbuild commented Nov 8, 2021

pgreen135 left a comment

Choose a reason for hiding this comment

pgreen135 commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

FNALbuild commented Nov 10, 2021

etyley commented Oct 28, 2021 •

edited

Loading