Cosmic InTime Workflow with Refactored LArG4

[marcodeltutto]

This PR adds a workflow for making intime samples with the new larg4 simulation. Fixes #147.

Depends on:

• Support multiple larg4 instances LArSoft/larg4#30
• Support multiple larg4 instances LArSoft/larsim#76

With the new larg4 we have a proliferation of modules that we need to run to get all the TPC, PDS, and CRT simulated products. It's much harder to bookkeep all of this when dealing with our intime workflow, where we first simulate in-time cosmics, then out-time ones, and then we merge them together. I made this flowchart to try and not forget anything, which I hope will be useful for the future as well.

The fcls to run are:

• prodcorsika_proton_intime_filter.fcl, or prodcorsika_proton_intime_filter_sce.fcl
• g4_simphotontime_filter.fcl
• standard_detsim_sbnd.fcl and the usuals...

[pgreen135]

trigger build LArSoft/larg4#30,LArSoft/larsim#76

[FNALbuild]

CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard

[FNALbuild]

CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

[FNALbuild]

CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

[FNALbuild]

CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for SBND Succeeded on slf7 for e20:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[pgreen135]

CI tests look good

[marcodeltutto]

Hi @pgreen135, larsoft v09_35_00 should have all the needed ingredients for this PR to work. Feel free to merge, thanks!

[pgreen135]

great, thanks @marcodeltutto; I saw there are some "known issues" mentioned in larsoft v09_35_00 release notes -- are these impacting this?

[marcodeltutto]

@pgreen135 They are not impacting this PR or the InTime workflow in general, but they limit our ability to use larg4 if we want to have two larg4 instances in the same job (in this PR I have 2 instances, but in two separate fcls). For the dirt workflow PR #203 for example is annoying to have this issue, but it's ok to have it fixed later.

[pgreen135]

Okay, in which case this looks good from my side. I'll wait for @jzennamo to also approve before merging.

[jzennamo]

This looks excellent! One quick question, does the CI test the in-time cosmic workflow laid out here? Have we tested that it does in fact run?

[pgreen135]

@jzennamo no, the CI does not run this -- you/Marco should definitely test this is working locally before we merge it!

[jzennamo]

OK! I merged this branch into v09_35_00 and I'll see if I can complete the same workflows Marco laid out above

[jzennamo]

OK, my findings:
For the gen stage I ran prodcorsika_proton_intime_filter_sce.fcl and got:
Events total = 500 passed = 4 failed = 496 --> ~1% pass rate, this matches what we had for MCP2020

Then I ran g4_sce_simphotontime_filter.fcl, detsim_sce.fcl, reco1_sce.fcl, and reco2_sce.root

In 4 events there is on average ~11 tracks which seems reasonable and they are reasonably distributed across the TPC.

one comment, the gen stage creates a "hist file" with _hists appended to the end, while all other stages add hists_ to the front, could this be changed before it is merged?

Save this one very minor comment I am happy for this to move forward!

[marcodeltutto]

Thanks @jzennamo! I fixed the hist file name with commit 9f057a4.

[jzennamo]

Approved! Thanks again!