717 test production mode in integration test #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bdegraaf1234
changed the base branch from
dev
to
732-append-managementportal-to-baseurl
Bdegraaf1234
changed the base branch from
732-append-managementportal-to-baseurl
to
dev
Bdegraaf1234
force-pushed
the
717-test-production-mode-in-integration-test
branch
from
e9b4b39
to
68fc25a
Compare
…nt operations being done
…ed for some setup during the job
…n as a local build.
…n as a local build.
production testing only runs on pre-release
…ript is unused in the repository and an untested copy of the github task in pre-release.yml.
There was a problem hiding this comment.
Thanks @Bdegraaf1234, looks good. Just a few questions (apologies if some are naive, i am looking at MP code after a long time).
| @@ -53,8 +53,6 @@ spring: | |||
| starttls.enable: false | |||
| thymeleaf: | |||
| cache: true | |||
| liquibase: | |||
| contexts: prod | |||
There was a problem hiding this comment.
does this need to be removed? Would it not be overridden by the e2e-prod-test profile?
There was a problem hiding this comment.
I moved it to the apllication.yml, the reasoning being that it is the default unless overriddedn by one of the dev profiles. Don't feel super strongly on this.
peyman-mohtashami
approved these changes
Nov 16, 2023
Bdegraaf1234
deleted the
717-test-production-mode-in-integration-test
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Include production testing in the github actions workflow to test postgres integration
Fixes #717
Checklist: