Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test production mode in integration test #717

Closed
blootsvoets opened this issue Sep 14, 2023 · 2 comments · Fixed by #736
Closed

Test production mode in integration test #717

blootsvoets opened this issue Sep 14, 2023 · 2 comments · Fixed by #736
Assignees

Comments

@blootsvoets
Copy link
Member

Currently, we only test ManagementPortal in dev mode in Github actions. This does not test the PostgreSQL integration. Ideally, we add a step to the Github Actions docker job to run the created docker image with docker-compose and test if it functions. A minimal implementation tests if ManagementPortal becomes healthy.

An example would be the first two services in https://github.com/RADAR-base/radar-app-config/blob/master/docker-compose.yml.

@Bdegraaf1234
Copy link
Member

When do we want to run prod-tests?

Since currently the prod e2e-tests and dev e2e-tests are identical it seems excessive to run both as part of the main.yml workflow. which do we run in main?

For release.yml and pre-release.yml I suggest we just run both.

Alternatively, we could probably make a profile of which tests to run in prod/dev but I don't think that would be worth it at this point.

@Bdegraaf1234
Copy link
Member

They run in pre-release now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants