Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation #128

Merged
merged 9 commits into from
May 9, 2024
Merged

Conversation

Nekothegamer
Copy link
Contributor

Support for italian

Added the strings.xml file which includes the italian translation done entirely by me (in just three hours and 40 minutes)
updated the strings.xml file with some minor error corrections
corrected yet another error on the strings.xml file, i hope it's the last one
i removed (or at least i hope it got removed) line 225, that should be the problem
@starry-shivam
Copy link
Member

Thanks for your contribution! It seems you're having some trouble with the CI, let me have look

@Nekothegamer
Copy link
Contributor Author

It seems you're having some trouble with the CI

yeah it keeps telling me there's a missing element on line 224, but i see nothing there

@Nekothegamer
Copy link
Contributor Author

so have you looked into it? i seriously can't figure it out

Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are quite a few unescaped ' characters. While I've tried to mark the ones I could, I would suggest verifying it once using a dedicated XML text editor. Such editors could point out these syntactic errors. Alternatively, you can try using Android Studio to edit them, as it will automatically point out these errors in the top right corner

app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
@Nekothegamer
Copy link
Contributor Author

oooohh
i get it now...

@Nekothegamer
Copy link
Contributor Author

god those are a lot of missing escapes, I'll modify all of them and upload everything as a new file

@starry-shivam
Copy link
Member

god those are a lot of missing escapes, I'll modify all of them and upload everything as a new file

No worries, take your time :)

corrected the file with the changes as indicated by the maintainer
@Nekothegamer
Copy link
Contributor Author

Nekothegamer commented May 9, 2024

nevermind, still that same error...

as indicated
@starry-shivam
Copy link
Member

starry-shivam commented May 9, 2024

@Nekothegamer i mean change it to <string name="ok">OK</string> the name is in smallcase while value is in upper case

@Nekothegamer
Copy link
Contributor Author

@Nekothegamer i mean change it to <string name="ok">OK</string> the name is in smallcase while value is in upper case

oh didn't see, changing it now

again, as indicated
@starry-shivam
Copy link
Member

@Nekothegamer i mean change it to <string name="ok">OK</string> the name is in smallcase while value is in upper case

oh didn't see, changing it now

You've done the opposite in last commit, the name/key should be smallcass and the value of the string needs to be in upper case :)

@Nekothegamer
Copy link
Contributor Author

@Nekothegamer i mean change it to <string name="ok">OK</string> the name is in smallcase while value is in upper case

oh didn't see, changing it now

You've done the opposite in last commit, the name/key should be smallcass and the value of the string needs to be in upper case :)

oh...

so <string name="OK">ok</string>?

@starry-shivam
Copy link
Member

@Nekothegamer i mean change it to <string name="ok">OK</string> the name is in smallcase while value is in upper case

oh didn't see, changing it now

You've done the opposite in last commit, the name/key should be smallcass and the value of the string needs to be in upper case :)

oh...

so <string name="OK">ok</string>?

It should be <string name="ok">OK</string> from name i mean name="ok" while the value is the one inside ><

@starry-shivam
Copy link
Member

Thanks, looks like there are still a few errors left, I'll take a look in a moment

@Nekothegamer
Copy link
Contributor Author

Thanks, looks like there are still a few errors left, I'll take a look in a moment

yeah i have no idea what's going on now, stuff just keeps popping up and the build keeps outputting the same error, I don't know what to do

it was this small...
@starry-shivam
Copy link
Member

Finally the CI is passing 🎉 Thanks for your patience and efforts :)

@starry-shivam starry-shivam merged commit 4bbb504 into Pool-Of-Tears:main May 9, 2024
1 check passed
@Nekothegamer
Copy link
Contributor Author

yes! it's been merged!!!!! thank you as well for your immense patience and sorry if i bothered you 😅

@starry-shivam
Copy link
Member

sorry if i bothered you 😅

Of course not! You've spent a significant amount of time translating those strings and contributing. In comparison, all I did was spend a few minutes pointing out some errors haha

@Nekothegamer
Copy link
Contributor Author

sorry if i bothered you 😅

Of course not! You've spent a significant amount of time translating those strings and contributing. In comparison, all I did was spend a few minutes pointing out some errors haha

oh well fair enough ¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯

thanks for merging anyway!

@Nekothegamer
Copy link
Contributor Author

can't wait for the translation to get released!

@starry-shivam
Copy link
Member

can't wait for the translation to get released!

I just created a release a few hours ago today, so the next release will take a while, probably around two weeks or so :)

@Nekothegamer
Copy link
Contributor Author

damn, this long?

@starry-shivam
Copy link
Member

damn, this long?

Well, yeah, I have some other plans to do before the next release, like implementing #104, which will take some time.

@Nekothegamer
Copy link
Contributor Author

oh, understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants