-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italian translation #128
Italian translation #128
Conversation
Added the strings.xml file which includes the italian translation done entirely by me (in just three hours and 40 minutes)
updated the strings.xml file with some minor error corrections
corrected yet another error on the strings.xml file, i hope it's the last one
i removed (or at least i hope it got removed) line 225, that should be the problem
Thanks for your contribution! It seems you're having some trouble with the CI, let me have look |
yeah it keeps telling me there's a missing element on line 224, but i see nothing there |
so have you looked into it? i seriously can't figure it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are quite a few unescaped '
characters. While I've tried to mark the ones I could, I would suggest verifying it once using a dedicated XML text editor. Such editors could point out these syntactic errors. Alternatively, you can try using Android Studio to edit them, as it will automatically point out these errors in the top right corner
oooohh |
god those are a lot of missing escapes, I'll modify all of them and upload everything as a new file |
No worries, take your time :) |
corrected the file with the changes as indicated by the maintainer
nevermind, still that same error... |
as indicated
@Nekothegamer i mean change it to |
oh didn't see, changing it now |
again, as indicated
You've done the opposite in last commit, the name/key should be smallcass and the value of the string needs to be in upper case :) |
oh... so |
It should be |
i hope it's right now
Thanks, looks like there are still a few errors left, I'll take a look in a moment |
yeah i have no idea what's going on now, stuff just keeps popping up and the build keeps outputting the same error, I don't know what to do |
Finally the CI is passing 🎉 Thanks for your patience and efforts :) |
yes! it's been merged!!!!! thank you as well for your immense patience and sorry if i bothered you 😅 |
Of course not! You've spent a significant amount of time translating those strings and contributing. In comparison, all I did was spend a few minutes pointing out some errors haha |
oh well fair enough ¯\_(ツ)_/¯ thanks for merging anyway! |
can't wait for the translation to get released! |
I just created a release a few hours ago today, so the next release will take a while, probably around two weeks or so :) |
damn, this long? |
Well, yeah, I have some other plans to do before the next release, like implementing #104, which will take some time. |
oh, understandable |
Support for italian