Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to 1.22.3 in environment_BSF.yml and environment_Windows.yml #124

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tnitka
Copy link
Collaborator

@tnitka tnitka commented Apr 23, 2024

Fixes #123.

tnitka and others added 2 commits April 23, 2024 14:17
changelog:
- Require hdbscan >= 0.8.29 to resolve installation errors (see: scikit-learn-contrib/hdbscan#565)
- Directly use available pip installable version of snekmer instead of git+github functionality
@christinehc
Copy link
Collaborator

christinehc commented May 8, 2024

@tnitka @jjacobson95 I added a specification for newer HDBSCAN versions due to installation errors arising from older versions of HDBSCAN, but have also updated the spec to use pip install snekmer rather than pip install -e git+https://github.com/PNNL-CompBio/Snekmer#egg=snekmer. I recommend these changes be tested before changes are merged into main

@christinehc
Copy link
Collaborator

christinehc commented May 28, 2024

Sidenote: HDBSCAN needs to be fixed to hdbscan==0.8.29 (and scikit-learn==1.2.2) due to this bug (see StackOverflow). I have updated this on the background branch but not on this one.

@christinehc
Copy link
Collaborator

We should bundle #125 fixes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply fails with single input file
2 participants