Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM-2 to NeMo checkpoint conversion #537

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Dec 16, 2024

Adds a conversion script to convert from huggingface to ESM-2 checkpoints

@pstjohn pstjohn force-pushed the pstjohn/hf-nemo-checkpoint-conversion branch 3 times, most recently from 046a747 to bd8668a Compare January 14, 2025 01:37
@pstjohn pstjohn changed the title Initial attempt for ESM-2 to NeMo checkpoint conversion ESM-2 to NeMo checkpoint conversion Jan 14, 2025
@pstjohn pstjohn marked this pull request as ready for review January 14, 2025 01:38
@pstjohn pstjohn requested review from jstjohn and sichu2023 January 14, 2025 01:38
Copy link
Collaborator

@sichu2023 sichu2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So neat. Learned something here.

target.txt Outdated Show resolved Hide resolved
source.txt Outdated Show resolved Hide resolved
@pstjohn pstjohn force-pushed the pstjohn/hf-nemo-checkpoint-conversion branch from bd8668a to de854e7 Compare January 14, 2025 15:08
Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can we close #180 once this merges?

Copy link
Collaborator

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pstjohn pstjohn force-pushed the pstjohn/hf-nemo-checkpoint-conversion branch from 1e42a13 to 4407b39 Compare January 21, 2025 20:10
@pstjohn pstjohn force-pushed the pstjohn/hf-nemo-checkpoint-conversion branch from 4407b39 to cc62c2b Compare January 21, 2025 22:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (eb89056) to head (d833763).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   86.63%   86.78%   +0.14%     
==========================================
  Files         116      118       +2     
  Lines        6966     7044      +78     
==========================================
+ Hits         6035     6113      +78     
  Misses        931      931              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pstjohn pstjohn enabled auto-merge January 22, 2025 19:15
@pstjohn pstjohn added this pull request to the merge queue Jan 22, 2025
Merged via the queue into NVIDIA:main with commit 257e918 Jan 22, 2025
10 of 14 checks passed
@pstjohn pstjohn deleted the pstjohn/hf-nemo-checkpoint-conversion branch January 22, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants