Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): Support secure bookmarks #221

Closed
wants to merge 1 commit into from
Closed

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Jan 3, 2025

Summary by Sourcery

Update the macos_secure_bookmarks dependency to the latest version from the main branch.

Bug Fixes:

  • Resolve issues related to missing secure bookmarks on iOS.

Enhancements:

  • Update the macos_secure_bookmarks package to the main branch to leverage the latest improvements and bug fixes.

Copy link

sourcery-ai bot commented Jan 3, 2025

Reviewer's Guide by Sourcery

This pull request updates the macos_secure_bookmarks dependency to use the latest version from the master branch. This is necessary to support secure bookmarks on iOS.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update macos_secure_bookmarks dependency
  • Change dependency from version 0.2.1 to the master branch
  • Update pubspec.lock file
pubspec.yaml
pubspec.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dosubot dosubot bot added the C - dependencies Pull requests that update a dependency file label Jan 3, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Using a Git dependency pointing to master is not recommended as it makes builds non-deterministic. Please either use the published package version or pin to a specific commit hash. If there's a specific reason for using the Git repository, please explain it in the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +70 to +72
git:
url: https://github.com/XMLHexagram/macos_secure_bookmarks.git
ref: master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Avoid using master branch reference for Git dependencies

Using a master branch reference can lead to build reproducibility issues and unexpected breaking changes. Consider pinning to a specific commit SHA instead.

Suggested implementation:

  macos_secure_bookmarks:
    git:
      url: https://github.com/XMLHexagram/macos_secure_bookmarks.git
      ref: 4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6

Note: The commit SHA I provided (4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6) is an example. The developer should verify this SHA is the correct version they want to use from the repository's commit history.

@Losses
Copy link
Owner

Losses commented Jan 4, 2025

I hope you're doing well. I wanted to address some important points regarding our workflow and repository management:

  1. Avoid Using the Master Branch: Under no circumstances should you use the master branch as a version identifier. It is not stable and can lead to unpredictable behavior.

  2. Use Your Own Fork for Modifications: As I previously mentioned privately, unless you are debugging CI, you should make modifications and submit them from your own fork, not by creating branches directly in this repository. This request is based on past issues where you created branches, made changes, but did not submit a PR or follow up in any way. While I believe your intention is to improve Rune, your past behavior has often left various issues for other maintainers to resolve. This repository cannot tolerate such practices.

  3. Final Warning: This is the last warning. Please remember, unless for CI debugging purposes, do not create branches in this repository. Failure to comply will result in revocation of your related permissions.

I understand that I should remain calm and supportive, helping every developer complete their tasks. However, repeated actions that create problems for other developers have tested my patience. I urge you to carefully consider whether your actions might inconvenience others before submitting a PR.

Thank you for your understanding and cooperation.

Copy link
Owner

@Losses Losses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check sourcery-ai's review

@XMLHexagram
Copy link
Collaborator Author

I highly understand and acknowledge your concerns. Deeply appreciate you for this detailed feedback regarding workflow practices.
I confirm that I have carefully read and fully understand all the good points raised, particularly regarding:

  • Not using the master branch
  • Making modifications through my own fork rather than direct repository branches
  • The importance of following the best PR procedures

Based on your feedback, I will:

  1. Close this PR
  2. Re-open it properly from my own fork following the specified guidelines
  3. Ensure all future contributions strictly follow to these workflow requirements

I appreciate your patience in addressing these issues. Rest assured that I have deeply internalized the best workflow practices and their profound importance in maintaining repository harmony. I look forward to demonstrating my newfound enlightenment regarding the proper ways of contribution. Your guidance has been illuminating.

Thank you again for this invaluable guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants