-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): Support secure bookmarks #221
Conversation
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XMLHexagram - I've reviewed your changes - here's some feedback:
Overall Comments:
- Using a Git dependency pointing to master is not recommended as it makes builds non-deterministic. Please either use the published package version or pin to a specific commit hash. If there's a specific reason for using the Git repository, please explain it in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
git: | ||
url: https://github.com/XMLHexagram/macos_secure_bookmarks.git | ||
ref: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Avoid using master branch reference for Git dependencies
Using a master branch reference can lead to build reproducibility issues and unexpected breaking changes. Consider pinning to a specific commit SHA instead.
Suggested implementation:
macos_secure_bookmarks:
git:
url: https://github.com/XMLHexagram/macos_secure_bookmarks.git
ref: 4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6
Note: The commit SHA I provided (4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6) is an example. The developer should verify this SHA is the correct version they want to use from the repository's commit history.
I hope you're doing well. I wanted to address some important points regarding our workflow and repository management:
I understand that I should remain calm and supportive, helping every developer complete their tasks. However, repeated actions that create problems for other developers have tested my patience. I urge you to carefully consider whether your actions might inconvenience others before submitting a PR. Thank you for your understanding and cooperation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check sourcery-ai's review
I highly understand and acknowledge your concerns. Deeply appreciate you for this detailed feedback regarding workflow practices.
Based on your feedback, I will:
I appreciate your patience in addressing these issues. Rest assured that I have deeply internalized the best workflow practices and their profound importance in maintaining repository harmony. I look forward to demonstrating my newfound enlightenment regarding the proper ways of contribution. Your guidance has been illuminating. Thank you again for this invaluable guidance. |
Summary by Sourcery
Update the
macos_secure_bookmarks
dependency to the latest version from the main branch.Bug Fixes:
Enhancements:
macos_secure_bookmarks
package to the main branch to leverage the latest improvements and bug fixes.