-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build issues caused by importing swift-rs #224
Conversation
Reviewer's Guide by SourceryThis pull request resolves build issues stemming from the incorrect inclusion of the Entity Relationship Diagram for Cargo.toml Dependency ChangeserDiagram
CARGO_TOML {
string tracing_appender
string chrono
string windows
string sha2
string anyhow
string vergen_git2
string tokio_with_wasm
string tracing_logcat
}
CARGO_TOML ||--o{ MACOS_DEPENDENCIES : "has"
MACOS_DEPENDENCIES {
string swift_rs
}
CARGO_TOML ||--o{ MACOS_BUILD_DEPENDENCIES : "has"
MACOS_BUILD_DEPENDENCIES {
string swift_rs
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XMLHexagram - I've reviewed your changes - here's some feedback:
Overall Comments:
- Ensure that the removal of 'swift-rs' from general dependencies does not affect the build process on non-macOS platforms.
- Consider adding a newline at the end of the file for consistent formatting.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
|
||
# Uncomment below to target the web. | ||
# tokio_with_wasm = { version = "0.6.0", features = ["sync", "rt"] } | ||
# wasm-bindgen = "0.2.92" | ||
|
||
# Android dependencies | ||
[target.'cfg(target_os = "android")'.dependencies] | ||
tracing-logcat = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF is removed, please recover the last empty line to ensure consistency.
Closed: ref #221 (comment) |
Summary by Sourcery
Build:
swift-rs
from general dependencies and add it as a dependency for macOS targets.