Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): Support secure bookmarks #221

Closed
wants to merge 1 commit into from
Closed

fix(iOS): Support secure bookmarks #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,11 +718,12 @@ packages:
macos_secure_bookmarks:
dependency: "direct main"
description:
name: macos_secure_bookmarks
sha256: c3163875f8fd530a1654a7cf8aa426e6e208d28bf05724a1d4960e4b7d2ca1c6
url: "https://pub.dev"
source: hosted
version: "0.2.1"
path: "."
ref: master
resolved-ref: c07abbf7c186c543de09a9c7df8577bbf5e27748
url: "https://github.com/XMLHexagram/macos_secure_bookmarks.git"
source: git
version: "0.2.0"
macos_window_utils:
dependency: transitive
description:
Expand Down
5 changes: 4 additions & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ dependencies:
very_good_infinite_list: ^0.9.0
flutter_fullscreen: ^1.0.1
device_info_plus: ^11.1.1
macos_secure_bookmarks: ^0.2.1
macos_secure_bookmarks:
git:
url: https://github.com/XMLHexagram/macos_secure_bookmarks.git
ref: master
Comment on lines +70 to +72
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Avoid using master branch reference for Git dependencies

Using a master branch reference can lead to build reproducibility issues and unexpected breaking changes. Consider pinning to a specific commit SHA instead.

Suggested implementation:

  macos_secure_bookmarks:
    git:
      url: https://github.com/XMLHexagram/macos_secure_bookmarks.git
      ref: 4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6

Note: The commit SHA I provided (4a9d943a5f8e5b3e29f3448c45c63941d5b5a0e6) is an example. The developer should verify this SHA is the correct version they want to use from the repository's commit history.

permission_handler: ^11.3.1
animated_flip_counter: ^0.3.4
intl: ^0.19.0
Expand Down
Loading