-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to Documenter v1 #444
Conversation
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 13 13
Lines 8728 8728
=======================================
Hits 7457 7457
Misses 1271 1271
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@mortenpi Is there a way to cross-reference docstrings from |
Nope, and that's non-trivial: JuliaDocs/Documenter.jl#688 |
Thank you very much for the quick response. Then I went in the right direction removing these references, many of which were somewhat overambitious (like |
I would defer to @mortenpi - since I am not familiar with the Documenter 1.0 changes yet. The docs do build, and the PR does look ok. |
Oh.. so this is a standard library, right? Those links do work when it gets built as part of the Julia manual: https://docs.julialang.org/en/v1/stdlib/SparseArrays/ So I think it would be better to leave them in for now? |
If we leave those in, then the docs CI test fails here. Is there a workaround? We could disable CI on docs, but then we have the problem of doc issues being discovered only when SparseArrays.jl is merged upstream in a julia build. |
I don't think there's an easy workaround here. I think the best thing we can do is to make them warnings here by adding |
I think that would be fine. At least it would allow us to catch more egregious problems sooner. Links are relatively easy to fix. |
good to go? |
Let's see if we need to exclude parts of the docs from the now default strict behavior.