Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Documenter v1 #444

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Adapt to Documenter v1 #444

merged 11 commits into from
Oct 10, 2023

Conversation

dkarrasch
Copy link
Member

Let's see if we need to exclude parts of the docs from the now default strict behavior.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #444 (d826b64) into main (713ab9b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          13       13           
  Lines        8728     8728           
=======================================
  Hits         7457     7457           
  Misses       1271     1271           
Files Coverage Δ
src/solvers/cholmod.jl 89.81% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dkarrasch
Copy link
Member Author

@mortenpi Is there a way to cross-reference docstrings from LinearAlgebra and Base (methods)? Is there a way to cross-reference to the "Random Numbers" section somewhere in the Base documentation? Perhaps an URL would work. But is that stable against new releases etc?

@mortenpi
Copy link
Contributor

Nope, and that's non-trivial: JuliaDocs/Documenter.jl#688

@dkarrasch
Copy link
Member Author

Thank you very much for the quick response. Then I went in the right direction removing these references, many of which were somewhat overambitious (like Float64).

@ViralBShah
Copy link
Member

I would defer to @mortenpi - since I am not familiar with the Documenter 1.0 changes yet. The docs do build, and the PR does look ok.

@mortenpi
Copy link
Contributor

Oh.. so this is a standard library, right? Those links do work when it gets built as part of the Julia manual: https://docs.julialang.org/en/v1/stdlib/SparseArrays/ So I think it would be better to leave them in for now?

@ViralBShah
Copy link
Member

ViralBShah commented Oct 3, 2023

If we leave those in, then the docs CI test fails here. Is there a workaround? We could disable CI on docs, but then we have the problem of doc issues being discovered only when SparseArrays.jl is merged upstream in a julia build.

@mortenpi
Copy link
Contributor

mortenpi commented Oct 3, 2023

I don't think there's an easy workaround here. I think the best thing we can do is to make them warnings here by adding :cross_references to warnonly. But some bad link then may still break the combined manual build.

@ViralBShah
Copy link
Member

I think that would be fine. At least it would allow us to catch more egregious problems sooner. Links are relatively easy to fix.

@matbesancon
Copy link
Contributor

good to go?

@ViralBShah ViralBShah merged commit e86b148 into main Oct 10, 2023
8 checks passed
@ViralBShah ViralBShah deleted the dk/documenter@v1 branch October 10, 2023 13:32
dkarrasch added a commit that referenced this pull request Oct 11, 2023
* Adapt to Documenter v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants