Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single header wrapper for all platforms. #446

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Sep 30, 2023

The headers are identical anyway, and this makes it possible to support unknown platforms, which is important as this package is part of the default Julia distribution.

Fixes #445

The headers are identical anyway, and this makes it possible to support
unknown platforms, which is important as this package is part of the
default Julia distribution.
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #446 (5551a81) into main (ac5c8ed) will decrease coverage by 7.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   93.20%   85.43%   -7.78%     
==========================================
  Files          12       13       +1     
  Lines        7700     8728    +1028     
==========================================
+ Hits         7177     7457     +280     
- Misses        523     1271     +748     
Files Coverage Δ
src/solvers/LibSuiteSparse.jl 100.00% <ø> (ø)
src/solvers/wrappers.jl 27.23% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ViralBShah
Copy link
Member

Should docs related failure wait on #444?

@ViralBShah ViralBShah merged commit 5dac134 into JuliaSparse:main Oct 2, 2023
6 of 8 checks passed
@maleadt maleadt deleted the single_header_wrapper branch October 2, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JLL-style LibSuiteSparse headers are incompatible with new platforms
2 participants