Add PhotonVisibilityExport module #64
Conversation
| voxel_dz: "10.00" # voxel z mesh step (in cm) | ||
| vis_model: "semianalytical" # visibility model to be used | ||
| # (pick one between "semianalytical", "compgraph") | ||
| do_refl: @local::dunefd_pdfastsim_par_ar_refl.DoReflectedLight |
There was a problem hiding this comment.
I am a bit puzzled here for VD: In principle there should be light reflected off from the anode but the following parameter is set to false...
Should there be two configurations, one for VD and another for HD here?
There was a problem hiding this comment.
Hi @lpaulucc, I have created three separate configurations for FD HD/VD-Ar/VD-Xe handling the reflection options like this
...
photovisexport_fdvd_ar.do_refl: @local::dunevd_pdfastsim_par_ar.DoReflectedLight
photovisexport_fdvd_ar.do_include_anode_refl: @local::dunevd_pdfastsim_par_ar.IncludeAnodeReflections
...
photovisexport_fdvd_xe.do_refl: @local::dunevd_pdfastsim_par_xe.DoReflectedLight
photovisexport_fdvd_xe.do_include_anode_refl: @local::dunevd_pdfastsim_par_xe.IncludeAnodeReflections
However if I check what is going on with a fhicl dump I still get no reflection for Xe light (at least for v09_88_00d00). Am I using the wrong reference?
| vishitspars: @local::dunefd_pdfastsim_par_ar_refl.VISHits | ||
| tfloaderpars: @local::dunevd_pdfastsim_ann_ar.TFLoaderTool | ||
|
|
||
| do_include_buffer: false |
There was a problem hiding this comment.
Is it possible to have this parameter true? If not, do you mind adding a comment here?
| physics.analyzers.photovisXe.vis_model: "semianalytical" | ||
| physics.analyzers.photovisXe.do_include_buffer: "true" | ||
| physics.analyzers.photovisXe.vuvhitspars: @local::dunevd_pdfastsim_par_xe.VUVHits | ||
| physics.analyzers.photovisXe.do_refl: false |
There was a problem hiding this comment.
There is not a reflected light in VD for Xe?
|
@dguff is this still a work in progress, or could it be ready to merge in 3-4 hours? I'd be happy to get it in to this week's release if you can answer the outstanding question and fix some of the conflicts with develop. |
|
Hi @lpaulucc @aolivier23, thank you for your comments! I still have to check that the changes I have made do actually work, I will try to get back to you as soon as I can and hopefully before 3-4 hours |
|
Yeah, I have just made a fhicl-dump of the VD config and indeed you find in there |
|
Unfortunately I could not make it @aolivier23, this one has to wait for the next release 😿 |
|
No worries. I'll check in next Friday. Thank you for the update. |
Introduce the PhotonVisibilityExport module, which evaluate the visibility of each OpDet in a grid of points inside the TPC. The PR also includes example fhicls and ROOT macros for building 2D and 3D visibility maps.