-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhotonVisibilityExport module #64
Open
dguff
wants to merge
10
commits into
DUNE:develop
Choose a base branch
from
MiB-DunePDS-Lab:v09_88_00d00_visibility_dump
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ae3374a
add module exporting visibility map and plotting/converting utils
dguff 5d15e09
minor editing to projection function
dguff c499d6f
Basic documentation
dguff d5b96c5
better handling of reflected light
dguff cf61952
split filling of vis map to reduce memory impact
dguff 4a76c13
Add README and example fhicls
dguff 2a25469
Add FD HD/VD configuration in standard fhicl
dguff f0dc76a
fixed typo in standard configuration sourcing
dguff 06ea769
Merge branch 'develop' into v09_88_00d00_visibility_dump
dguff 2b3f2ca
Add variable to set visibility sampling size
dguff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #include "PDFastSim_dune.fcl" | ||
|
|
||
| BEGIN_PROLOG | ||
|
|
||
| standard_photovisexport: | ||
| { | ||
| module_type: "PhotonVisibilityExport" | ||
| photovis_label: "photovisexport" | ||
| photovis_map: "photovisexport" | ||
| voxel_dx: "10.00" # voxel x mesh step (in cm) | ||
| voxel_dy: "10.00" # voxel y mesh step (in cm) | ||
| voxel_dz: "10.00" # voxel z mesh step (in cm) | ||
| vis_model: "semianalytical" # visibility model to be used | ||
| # (pick one between "semianalytical", "compgraph") | ||
| do_refl: @local::dunefd_pdfastsim_par_ar_refl.DoReflectedLight | ||
| do_include_anode_refl: false | ||
| vuvhitspars: @local::dunefd_pdfastsim_par_ar.VUVHits | ||
| vishitspars: @local::dunefd_pdfastsim_par_ar_refl.VISHits | ||
| tfloaderpars: @local::dunevd_pdfastsim_ann_ar.TFLoaderTool | ||
|
|
||
| do_include_buffer: true # include buffer region using the PhotonVisibilityService | ||
| } | ||
|
|
||
| photovisexport_fdhd: @local::standard_photovisexport | ||
|
|
||
| photovisexport_fdvd_ar: @local::standard_photovisexport | ||
| photovisexport_fdvd_ar.vuvhitspars: @local::dunevd_pdfastsim_par_ar.VUVHits | ||
| photovisexport_fdvd_ar.do_refl: @local::dunevd_pdfastsim_par_ar.DoReflectedLight | ||
| photovisexport_fdvd_ar.do_include_anode_refl: @local::dunevd_pdfastsim_par_ar.IncludeAnodeReflections | ||
|
|
||
| photovisexport_fdvd_xe: @local::standard_photovisexport | ||
| photovisexport_fdvd_xe.vuvhitspars: @local::dunevd_pdfastsim_par_xe.VUVHits | ||
| photovisexport_fdvd_xe.do_refl: @local::dunevd_pdfastsim_par_xe.DoReflectedLight | ||
| photovisexport_fdvd_xe.do_include_anode_refl: @local::dunevd_pdfastsim_par_xe.IncludeAnodeReflections | ||
|
|
||
| END_PROLOG | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit puzzled here for VD: In principle there should be light reflected off from the anode but the following parameter is set to false...
Should there be two configurations, one for VD and another for HD here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lpaulucc, I have created three separate configurations for FD HD/VD-Ar/VD-Xe handling the reflection options like this
However if I check what is going on with a fhicl dump I still get no reflection for Xe light (at least for v09_88_00d00). Am I using the wrong reference?