Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PhotonVisibilityExport module #64

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add PhotonVisibilityExport module #64

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae3374a
add module exporting visibility map and plotting/converting utils
dguff Oct 18, 2024
5d15e09
minor editing to projection function
dguff Oct 22, 2024
c499d6f
Basic documentation
dguff Oct 22, 2024
d5b96c5
better handling of reflected light
dguff Oct 23, 2024
cf61952
split filling of vis map to reduce memory impact
dguff Oct 23, 2024
4a76c13
Add README and example fhicls
dguff Oct 23, 2024
2a25469
Add FD HD/VD configuration in standard fhicl
dguff Nov 8, 2024
f0dc76a
fixed typo in standard configuration sourcing
dguff Nov 8, 2024
06ea769
Merge branch 'develop' into v09_88_00d00_visibility_dump
dguff Nov 14, 2024
2b3f2ca
Add variable to set visibility sampling size
dguff Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ find_ups_root()
find_ups_product( cetbuildtools )
find_ups_product( larevt )
find_ups_product( larsim )
find_ups_product( eigen )
find_ups_product( tensorflow )
find_ups_product( larsimdnn )
find_ups_product( larcore )
find_ups_product( lardata )
find_ups_product( lardataalg )
Expand Down
105 changes: 57 additions & 48 deletions duneopdet/PhotonPropagation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,63 @@

art_make(
SERVICE_LIBRARIES larsim_PhotonPropagation
larsim::Simulation nug4::ParticleNavigation
lardataobj::Simulation
larevt::Filters
lardataobj::RawData
larcorealg::Geometry
larcore::Geometry_Geometry_service
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
ROOT::Core
art_root_io::TFileService_service
art::Framework_Services_Optional_RandomNumberGenerator_service
art::Persistency_Common
art::Persistency_Provenance
art::Utilities
canvas::canvas
messagefacility::MF_MessageLogger
fhiclcpp::fhiclcpp
CLHEP
cetlib::cetlib cetlib_except
ROOT_BASIC_LIB_LIST
ROOT_EG
SERVICE_LIBRARIES
larsim_PhotonPropagation
larsim::Simulation nug4::ParticleNavigation
lardataobj::Simulation
larevt::Filters
lardataobj::RawData
larcorealg::Geometry
larcore::Geometry_Geometry_service
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
ROOT::Core
art_root_io::TFileService_service
art::Framework_Services_Optional_RandomNumberGenerator_service
art::Persistency_Common
art::Persistency_Provenance
art::Utilities
canvas::canvas
messagefacility::MF_MessageLogger
fhiclcpp::fhiclcpp
CLHEP
cetlib::cetlib cetlib_except
ROOT_BASIC_LIB_LIST
ROOT_EG

MODULE_LIBRARIES
ROOT_BASIC_LIB_LIST
larsim::LegacyLArG4
lardataobj::Simulation
duneopdet::PhotonPropagation_PhotonVisibilityServiceS2_service
larsim::Simulation
nug4::ParticleNavigation lardataobj_Simulation
larcorealg::Geometry
larcore::Geometry_Geometry_service
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
ROOT::Core
art_root_io::TFileService_service
art::Framework_Services_Optional_RandomNumberGenerator_service
nurandom::RandomUtils_NuRandomService_service
art::Persistency_Common
art::Persistency_Provenance
art::Utilities
canvas::canvas
messagefacility::MF_MessageLogger
fhiclcpp::fhiclcpp
cetlib::cetlib cetlib_except
CLHEP

ROOT_BASIC_LIB_LIST
larsim::LegacyLArG4
lardataobj::Simulation
duneopdet::PhotonPropagation_PhotonVisibilityServiceS2_service
larsim::PhotonPropagation_PhotonVisibilityService_service
larsim::Simulation
larsim::PhotonPropagation
TensorFlow::cc
TensorFlow::framework
larsimdnn::TFLoaderTool

nug4::ParticleNavigation lardataobj_Simulation
larcorealg::Geometry
larcore::Geometry_Geometry_service
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
ROOT::Core
art_root_io::TFileService_service
art::Framework_Services_Optional_RandomNumberGenerator_service
nurandom::RandomUtils_NuRandomService_service
art::Persistency_Common
art::Persistency_Provenance
art::Utilities
canvas::canvas
messagefacility::MF_MessageLogger
fhiclcpp::fhiclcpp
cetlib::cetlib cetlib_except
CLHEP
)

install_headers()
Expand Down
25 changes: 25 additions & 0 deletions duneopdet/PhotonPropagation/PhotonVisibilityExport.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#include "PDFastSim_dune.fcl"

BEGIN_PROLOG

standard_photovis:
{
module_type: "PhotonVisibilityExport"
photovis_label: "photovis"
photovis_map: "photovis"
voxel_dx: "10.00" # voxel x mesh step (in cm)
voxel_dy: "10.00" # voxel y mesh step (in cm)
voxel_dz: "10.00" # voxel z mesh step (in cm)
vis_model: "semianalytical" # visibility model to be used
# (pick one between "semianalytical", "compgraph")
do_refl: @local::dunefd_pdfastsim_par_ar_refl.DoReflectedLight
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit puzzled here for VD: In principle there should be light reflected off from the anode but the following parameter is set to false...
Should there be two configurations, one for VD and another for HD here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpaulucc, I have created three separate configurations for FD HD/VD-Ar/VD-Xe handling the reflection options like this

...
photovisexport_fdvd_ar.do_refl: @local::dunevd_pdfastsim_par_ar.DoReflectedLight
photovisexport_fdvd_ar.do_include_anode_refl: @local::dunevd_pdfastsim_par_ar.IncludeAnodeReflections
...
photovisexport_fdvd_xe.do_refl: @local::dunevd_pdfastsim_par_xe.DoReflectedLight
photovisexport_fdvd_xe.do_include_anode_refl: @local::dunevd_pdfastsim_par_xe.IncludeAnodeReflections

However if I check what is going on with a fhicl dump I still get no reflection for Xe light (at least for v09_88_00d00). Am I using the wrong reference?

do_include_anode_refl: false
vuvhitspars: @local::dunefd_pdfastsim_par_ar.VUVHits
vishitspars: @local::dunefd_pdfastsim_par_ar_refl.VISHits
tfloaderpars: @local::dunevd_pdfastsim_ann_ar.TFLoaderTool

do_include_buffer: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have this parameter true? If not, do you mind adding a comment here?

}

END_PROLOG

Loading