Rover: add require-position-for-arming option #29073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
changed the title
peterbarker
changed the title
Hwurzburg
reviewed
Jan 14, 2025
peterbarker
force-pushed
the
pr/rover-require-position-for-arming
branch
from
2a2c165 to
f77f66e
Compare
|
Hi @peterbarker, thanks for this. I've already commented on the other PR but shouldn't this be in ARMING_OPTIONS? I see in Copter we've put it in flight options but I wonder why.. |
peterbarker
force-pushed
the
pr/rover-require-position-for-arming
branch
from
f77f66e to
d534e0b
Compare
peterbarker
changed the title
peterbarker
force-pushed
the
pr/rover-require-position-for-arming
branch
2 times, most recently
from
12e11b0 to
b1c6479
Compare
peterbarker
force-pushed
the
pr/rover-require-position-for-arming
branch
from
b1c6479 to
7db9428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #29066 as it's really a separate feature
Tested in SITL, including autotest