-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for passing blob directory path #16
Add configuration option for passing blob directory path #16
Conversation
Thank you for you contribution. We require all contributors to sign the Zope contributor agreement before we can merge the code, please see https://www.zope.dev/developer/becoming-a-committer.html |
Done. |
@FarooqAlaulddin Could you please run the tests locally using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the comment is removed this looks good, thank you.
Remove test unit comment.
Great! |
@FarooqAlaulddin Once a PR is ready for merging (all issues fixed, approvals given) the author can do the merge, so just go ahead and do so. |
Just released as https://pypi.org/project/zope.mkzeoinstance/5.1/. |
This PR seems to cause plone/plone.recipe.zeoserver#45 (comment) |
I've fixed that here #18 |
PL
To address #15.
-b, --blobs
is optional.Tests
3 new test units were added:
Other unit tests edited to reflect the change.
Test Status: