Dependency fix

[petschki]

Dependency on ZEO and zdaemon are lost when defining additional eggs in the recipe. Make sure we do not loose our required dependencies in that case.

see discussion https://community.plone.org/t/plone-6-0-4-released/17406/7?u=petschki

[mister-roboto]

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[petschki]

@jenkins-plone-org please run jobs

[petschki]

I think this issue gets fixed with this too #29

[petschki]

pre-commit.ci autofix

[petschki]

@jenkins-plone-org please run jobs

[mauritsvanrees]

Mostly good, thanks! One inline comment with a small request for Windows, but that is really unrelated to this PR.

But with the plone/meta changes we also run pyupgrade to convert the code to Python 3.8+ only. And latest black is run. So this will break Python 2 compatibility. So this is a breaking change.

I am okay with that. But it means the setup.py can be cleaned up a bit more, changelog updated. maybe the readme.

I have created a 2.x branch from current master, and have let coredev 5.2 use this.

[mauritsvanrees]

BTW, I don't think this has any influence on Jenkins, so those jobs do not need to run. We should let mr.roboto ignore this repo.

[mauritsvanrees]

BTW, I don't think this has any influence on Jenkins, so those jobs do not need to run. We should let mr.roboto ignore this repo.

Okay, I added this in a mr.roboto PR that I already created earlier today for something else.

[petschki]

@jenkins-plone-org please run jobs

[petschki]

Can anyone activate GHA here?

[mauritsvanrees]

Can anyone activate GHA here?

The central workflow? Done.

[petschki]

@jenkins-plone-org please run jobs

[petschki]

@jenkins-plone-org please run jobs

[petschki]

I testet this on my Parallels Win11 and it worked. Tests are also fixed. @mauritsvanrees what do you think?

[petschki]

@icemac we are pinning zope.mkzeoinstance=5.0 for Plone 6.0 because on 5.1 there's a traceback:

Traceback (most recent call last):
  File "/Users/peterm/.pyenv/versions/3.11.3/envs/py-3.11-familienpass/lib/python3.11/site-packages/zc/buildout/buildout.py", line 2252, in main
    getattr(buildout, command)(args)
  File "/Users/peterm/.pyenv/versions/3.11.3/envs/py-3.11-familienpass/lib/python3.11/site-packages/zc/buildout/buildout.py", line 856, in install
    installed_files = self[part]._call(recipe.install)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/peterm/.pyenv/versions/3.11.3/envs/py-3.11-familienpass/lib/python3.11/site-packages/zc/buildout/buildout.py", line 1652, in _call
    return f()
           ^^^
  File "/Users/peterm/workspace/familienpass/src/plone.recipe.zeoserver/src/plone/recipe/zeoserver/recipe.py", line 88, in install
    ZEOInstanceBuilder().create(location, params)
  File "/Users/peterm/workspace/familienpass/eggs/zope.mkzeoinstance-5.1-py3.11.egg/zope/mkzeoinstance/__init__.py", line 188, in create
    makefile(ZEO_CONF_TEMPLATE, home, "etc", "zeo.conf", **params)
  File "/Users/peterm/workspace/familienpass/eggs/zope.mkzeoinstance-5.1-py3.11.egg/zope/mkzeoinstance/__init__.py", line 256, in makefile
    data = template % kwds
           ~~~~~~~~~^~~~~~
KeyError: 'blob_dir'

do we have to take care about that in this recipe, or is this a bug in zope.mkzeoinstance ?

[icemac]

@petschki The problem with zope.mkzeoinstance was probably introduced by zopefoundation/zope.mkzeoinstance#16 which added support for blob_dir, so it should be fixed over there. (A PR is welcome.)

[mauritsvanrees]

I testet this on my Parallels Win11 and it worked. Tests are also fixed. @mauritsvanrees what do you think?

Looking good now. Thanks!