compiler-rt: memmove optimisation #22606
Draft
+221
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
reviewed
Jan 25, 2025
| @@ -18,7 +18,7 @@ comptime { | |||
| } | |||
| } | |||
|
|
|||
| const Element = if (std.simd.suggestVectorLength(u8)) |vec_size| | |||
| pub const Element = if (std.simd.suggestVectorLength(u8)) |vec_size| | |||
There was a problem hiding this comment.
maybe just put them back in the same file, like it was before?
There was a problem hiding this comment.
I could, especially if it ends up making sense to share significant parts of their implementations. I was actually planning to move Element into common.zig (with a more descriptive name) since memset is going to want it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to improve
memmoveperformance and fix some issues with generated code size of the current compiler-rtmemmove.I haven't yet benchmarked this implementation, though I expect the impact to be similar to #18912.
For
ReleastFastcode size:arm-freestandingcortex_m4Todo:
memcpy