Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt memcpy followup #22615

Merged
merged 1 commit into from
Jan 26, 2025
Merged

compiler-rt memcpy followup #22615

merged 1 commit into from
Jan 26, 2025

Conversation

dweiller
Copy link
Contributor

@dweiller dweiller commented Jan 26, 2025 •
edited
Loading

Fixing some issues with #18912.

cc @jacobly0, the memmove issue should be resolved by #22606.

jacobly0
jacobly0 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@jacobly0 jacobly0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that usize has a power of two size which is not true for all targets, but I have no problem since there is a comptime check that can be handled if we ever do support one of them.

@andrewrk andrewrk enabled auto-merge (rebase) January 26, 2025 05:24
@andrewrk andrewrk merged commit df1cd62 into ziglang:master Jan 26, 2025
10 checks passed
@dweiller dweiller deleted the memcpy-followup branch January 28, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobly0 jacobly0 jacobly0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweiller @jacobly0 @andrewrk